feat(transaction-pay-controller): add HyperLiquid source quote support for Perps Withdraw by dan437 · Pull Request #8285 · MetaMask/core

dan437 · 2026-03-24T14:36:55Z

Explanation

Adds HyperLiquid source quote support for Perps Withdraw. With this we will be able to show a quote for Perps Withdraw on a client.

References

Fixes https://consensyssoftware.atlassian.net/browse/CONF-1089

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Extends Relay quote normalization and fee/gas estimation with HyperLiquid-specific behavior (chain/token overrides, decimal shifting, gasless fees), which could affect quote accuracy and submission behavior for related flows if misapplied.

Overview
Adds an isHyperliquidSource flag that is persisted via setTransactionConfig and propagated into quote requests.

When isHyperliquidSource is set, Relay quoting now normalizes the source to HyperCore Perps USDC, shifts amounts for the 8→6 decimal mismatch, uses Arbitrum USDC pricing for fiat rates, and zeros out source network fees/gas limits for gasless withdrawals.

Also refines Relay step typing to support non-transaction steps (signature and HyperLiquid deposit shapes) and updates gas/submit logic to only process transaction steps while rejecting unsupported kinds; tests and the changelog are updated accordingly.

^{Written by Cursor Bugbot for commit 581aa20. This will update automatically on new commits. Configure here.}

packages/transaction-pay-controller/src/strategy/relay/relay-submit.ts

packages/transaction-pay-controller/src/constants.ts

packages/transaction-pay-controller/src/strategy/relay/relay-max-gas-station.ts

packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts

packages/transaction-pay-controller/src/constants.ts

packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts

packages/transaction-pay-controller/src/strategy/relay/types.ts

packages/transaction-pay-controller/src/types.ts

packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts

packages/transaction-pay-controller/src/strategy/relay/relay-submit.ts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

packages/transaction-pay-controller/src/strategy/relay/types.ts

…t for Perps Withdraw Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

…l shift Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

…on via Relay (#8314) ## Explanation The quote support for Perps Withdraw was added in #8285. This PR completes the feature by adding the **submission flow** — the 2-step gasless withdrawal from HyperLiquid via Relay. When `isHyperliquidSource` is set on the transaction config, `executeSingleQuote` now routes to `submitHyperliquidWithdraw` instead of `submitTransactions`. This function executes two EIP-712 signing steps: 1. **Authorize** — signs a nonce-mapping message and POSTs the signature to Relay's `/authorize` endpoint, linking the HyperLiquid withdrawal to the Relay order. 2. **Deposit** — signs a HyperLiquid `sendAsset` action and POSTs it to the HyperLiquid exchange API, instructing HL to transfer funds to the Relay solver. After both steps complete, the existing `waitForRelayCompletion` polling takes over to track the cross-chain fill on the destination chain. ### Key changes - **New file `hyperliquid-withdraw.ts`** — implements `submitHyperliquidWithdraw` with the 2-step authorize + deposit flow, EIP-712 domain derivation, and signature `r/s/v` parsing for the HyperLiquid exchange API format. - **`relay-submit.ts`** — routes to `submitHyperliquidWithdraw` when `isHyperliquidSource` is true; no changes to `waitForRelayCompletion` or existing submission logic. - **`types.ts`** — adds `KeyringControllerSignTypedMessageAction` to `AllowedActions` (required for silent EIP-712 signing via the keyring controller messenger). - **`constants.ts`** — adds `RELAY_AUTHORIZE_URL` and `HYPERLIQUID_EXCHANGE_URL` endpoints. ## References - Follows up on #8285 (HyperLiquid source quote support) - Related to MetaMask/MetaMask-planning#6805, MetaMask/MetaMask-planning#6806 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them  --- > [!NOTE] > **High Risk** > Adds a new HyperLiquid withdrawal submission path that performs *silent* EIP-712 signing and posts signatures to external Relay/HyperLiquid endpoints, plus a breaking messenger permission expansion. Incorrect step parsing/signature construction or permission wiring could cause failed withdrawals or unintended signing behavior. > > **Overview** > Adds a new **HyperLiquid withdrawal submission flow** for the Relay strategy: when `quote.request.isHyperliquidSource` is set, `relay-submit` skips on-chain `TransactionController` submissions and instead runs a two-step `submitHyperliquidWithdraw` flow (Relay `/authorize` EIP-712 signature, then HyperLiquid exchange `sendAsset` EIP-712 signature + `r/s/v` POST), before continuing with the existing Relay status polling. > > Introduces new endpoints (`RELAY_AUTHORIZE_URL`, `HYPERLIQUID_EXCHANGE_URL`), adds comprehensive unit tests for the new withdraw module and the new routing branch, and **expands `AllowedActions` with `KeyringControllerSignTypedMessageAction` (breaking)** so clients must grant `KeyringController:signTypedMessage` when constructing the controller messenger. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3240f3d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>  --------- Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

dan437 requested a review from a team as a code owner March 24, 2026 14:36

dan437 commented Mar 24, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/relay/relay-submit.ts Show resolved Hide resolved

cursor bot reviewed Mar 24, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/relay/relay-submit.ts Show resolved Hide resolved

matthewwalsh0 previously approved these changes Mar 24, 2026

View reviewed changes

matthewwalsh0 added the team-confirmations label Mar 24, 2026

dan437 dismissed matthewwalsh0’s stale review via f1735c0 March 25, 2026 11:05

dan437 force-pushed the perps-withdraw-quote branch from c6e2d66 to f1735c0 Compare March 25, 2026 11:05

cursor bot reviewed Mar 25, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts Show resolved Hide resolved

packages/transaction-pay-controller/src/strategy/relay/relay-submit.ts Show resolved Hide resolved

dan437 force-pushed the perps-withdraw-quote branch from f1735c0 to 4c7c632 Compare March 25, 2026 12:55

cursor bot reviewed Mar 25, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/relay/types.ts Show resolved Hide resolved

dan437 added 14 commits March 25, 2026 15:00

feat(transaction-pay-controller): add HyperLiquid source quote suppor…

1fd1780

…t for Perps Withdraw Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Refactoring

020736f

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Add casting

80deaf3

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Remove protocolVersion v2

7448595

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Code cleanup

ede9dfc

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Define HYPERCORE_USDC_DECIMALS and USDC_DECIMALS, use it for a decima…

7cd1b8e

…l shift Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Update the steps type

715baf6

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Alphabetical order

e03373c

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Allow “signature” as a valid step

d9825b9

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Fix linting

c489044

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Resolve Bugbot comment and linting

6d53ed6

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Linting

f38d4c8

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Linting

36571e1

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Update changelog

581aa20

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

dan437 force-pushed the perps-withdraw-quote branch from 449cf5e to 581aa20 Compare March 25, 2026 14:01

dan437 requested a review from a team as a code owner March 25, 2026 14:01

dan437 enabled auto-merge March 25, 2026 14:10

matthewwalsh0 approved these changes Mar 25, 2026

View reviewed changes

dan437 added this pull request to the merge queue Mar 25, 2026

Merged via the queue into main with commit 45aa4e2 Mar 25, 2026
326 checks passed

dan437 deleted the perps-withdraw-quote branch March 25, 2026 16:21

dan437 mentioned this pull request Mar 26, 2026

feat(transaction-pay-controller): add HyperLiquid withdrawal submission via Relay #8314

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(transaction-pay-controller): add HyperLiquid source quote support for Perps Withdraw#8285

feat(transaction-pay-controller): add HyperLiquid source quote support for Perps Withdraw#8285
dan437 merged 14 commits intomainfrom
perps-withdraw-quote

dan437 commented Mar 24, 2026 •

edited by cursor bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dan437 commented Mar 24, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dan437 commented Mar 24, 2026 •

edited by cursor bot

Loading