fix: normalized token address before the payment token comparison#8297
Merged
fix: normalized token address before the payment token comparison#8297
Conversation
chaitanyapotti
previously approved these changes
Mar 25, 2026
ef2e13f to
33abe9e
Compare
chaitanyapotti
previously approved these changes
Mar 25, 2026
hieu-w
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR addresses ~
SubscriptionController#getCryptoApproveTransactionParams.Testing
yarn workspace @metamask/subscription-controller run changelog:validateReferences
Checklist
Note
Low Risk
Low risk: a small change to token-address matching when building crypto approve params, plus a targeted regression test; only behavior change is accepting mixed-case/checksummed addresses that previously errored.
Overview
Fixes
SubscriptionController#getCryptoApproveTransactionParamsto normalize payment token address comparisons (lowercasing both sides) so mixed-case/checksummed token addresses no longer fail with "Invalid token address".Adds a Jest regression test covering case-insensitive token matching, and records the change in the
@metamask/subscription-controllerchangelog.Written by Cursor Bugbot for commit 91c17b2. This will update automatically on new commits. Configure here.