fix: do not fetch payment methods until a user has selected a token#8342
Open
georgeweiler wants to merge 3 commits intomainfrom
Open
fix: do not fetch payment methods until a user has selected a token#8342georgeweiler wants to merge 3 commits intomainfrom
georgeweiler wants to merge 3 commits intomainfrom
Conversation
Contributor
Author
|
@cursoragent fix the changelog |
|
Excellent! I've successfully fixed the changelog by replacing the placeholder SummaryFixed the changelog validation error by updating the PR reference in |
Co-authored-by: George Weiler <georgejweiler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Explanation
Fixes a small bug where payment methods were fetched and set prematurely.
References
Checklist
Note
Low Risk
Low risk bug fix that only tightens the conditions for when
getPaymentMethodsis triggered, with updated tests and changelog entry to match.Overview
Prevents
setSelectedProviderfrom callinggetPaymentMethodsunless a token is selected and that token isn’t explicitly excluded by the provider, avoiding unfiltered payment-method fetches with an emptycryptoparameter.Updates unit tests to require a selected token for the “no
supportedCryptoCurrenciesfield” case and adds a new test asserting the fetch is skipped when no token is selected, plus a changelog entry documenting the fix.Written by Cursor Bugbot for commit a2ba97f. This will update automatically on new commits. Configure here.