Skip to content

feat(keyring-controller): add KeyringTypes.money#8360

Merged
ccharly merged 3 commits intomainfrom
cc/feat/keyring-controller-money-keyring
Apr 1, 2026
Merged

feat(keyring-controller): add KeyringTypes.money#8360
ccharly merged 3 commits intomainfrom
cc/feat/keyring-controller-money-keyring

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Apr 1, 2026

Explanation

Declare the new Money keyring value, associated with @metamask/eth-money-keyring.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: this only extends the KeyringTypes enum and updates the package changelog, with no behavioral or security-sensitive logic changes.

Overview
Adds a new KeyringTypes.money enum value ("Money Keyring") in KeyringController.ts so consumers can reference the Money keyring type consistently.

Updates the @metamask/keyring-controller changelog to announce the new enum value.

Written by Cursor Bugbot for commit 19e4005. This will update automatically on new commits. Configure here.

@ccharly ccharly marked this pull request as ready for review April 1, 2026 14:39
@ccharly ccharly requested review from a team as code owners April 1, 2026 14:39
@ccharly ccharly force-pushed the cc/feat/keyring-controller-money-keyring branch from 0a88a81 to 6942348 Compare April 1, 2026 14:40
@ccharly ccharly added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit b8ccf5a Apr 1, 2026
332 checks passed
@ccharly ccharly deleted the cc/feat/keyring-controller-money-keyring branch April 1, 2026 14:56
micaelae pushed a commit that referenced this pull request Apr 7, 2026
## Explanation

Declare the new Money keyring value, associated with
`@metamask/eth-money-keyring`.

## References

N/A

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: this only extends the `KeyringTypes` enum and updates the
package changelog, with no behavioral or security-sensitive logic
changes.
> 
> **Overview**
> Adds a new `KeyringTypes.money` enum value (`"Money Keyring"`) in
`KeyringController.ts` so consumers can reference the Money keyring type
consistently.
> 
> Updates the `@metamask/keyring-controller` changelog to announce the
new enum value.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
19e4005. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants