feat(keyring-controller): add KeyringTypes.money#8360
Merged
Conversation
0a88a81 to
6942348
Compare
david0xd
approved these changes
Apr 1, 2026
montelaidev
approved these changes
Apr 1, 2026
micaelae
pushed a commit
that referenced
this pull request
Apr 7, 2026
## Explanation Declare the new Money keyring value, associated with `@metamask/eth-money-keyring`. ## References N/A ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this only extends the `KeyringTypes` enum and updates the package changelog, with no behavioral or security-sensitive logic changes. > > **Overview** > Adds a new `KeyringTypes.money` enum value (`"Money Keyring"`) in `KeyringController.ts` so consumers can reference the Money keyring type consistently. > > Updates the `@metamask/keyring-controller` changelog to announce the new enum value. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 19e4005. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Declare the new Money keyring value, associated with
@metamask/eth-money-keyring.References
N/A
Checklist
Note
Low Risk
Low risk: this only extends the
KeyringTypesenum and updates the package changelog, with no behavioral or security-sensitive logic changes.Overview
Adds a new
KeyringTypes.moneyenum value ("Money Keyring") inKeyringController.tsso consumers can reference the Money keyring type consistently.Updates the
@metamask/keyring-controllerchangelog to announce the new enum value.Written by Cursor Bugbot for commit 19e4005. This will update automatically on new commits. Configure here.