chore: Update bridge controllers to expose all methods through messenger#8367
Merged
chore: Update bridge controllers to expose all methods through messenger#8367
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
0377135 to
0aa1851
Compare
cryptodev-2s
approved these changes
Apr 2, 2026
bfullam
approved these changes
Apr 7, 2026
OGPoyraz
approved these changes
Apr 7, 2026
micaelae
pushed a commit
that referenced
this pull request
Apr 7, 2026
…ger (#8367) This updates the following controllers to expose all methods through the messenger in a standardised way: - `BridgeController`. - `BridgeStatusController`. <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes are limited to new TypeScript action type exports, a build-time generation script dependency, and test refactoring; no bridge runtime logic is modified. > > **Overview** > Adds an auto-generated `bridge-controller-method-action-types.ts` that defines and exports **per-method** messenger action types (e.g., `BridgeControllerFetchQuotesAction`) for all public `BridgeController` methods, and documents/deprecates the older aggregated action types in the changelog. > > Updates `package.json` to support generating these types via a new `generate-method-action-types` script (adding `tsx`), and refactors the `BridgeController` SSE tests to exercise the controller through a real `@metamask/messenger` instance (`rootMessenger.call(...)`) instead of a hand-rolled messenger mock. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 56740c7. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This updates the following controllers to expose all methods through the messenger in a standardised way:
BridgeController.BridgeStatusController.References
Checklist
Note
Low Risk
Low risk: changes are limited to new TypeScript action type exports, a build-time generation script dependency, and test refactoring; no bridge runtime logic is modified.
Overview
Adds an auto-generated
bridge-controller-method-action-types.tsthat defines and exports per-method messenger action types (e.g.,BridgeControllerFetchQuotesAction) for all publicBridgeControllermethods, and documents/deprecates the older aggregated action types in the changelog.Updates
package.jsonto support generating these types via a newgenerate-method-action-typesscript (addingtsx), and refactors theBridgeControllerSSE tests to exercise the controller through a real@metamask/messengerinstance (rootMessenger.call(...)) instead of a hand-rolled messenger mock.Written by Cursor Bugbot for commit 56740c7. This will update automatically on new commits. Configure here.