Skip to content

chore: Update bridge controllers to expose all methods through messenger#8367

Merged
Mrtenz merged 8 commits intomainfrom
mrtenz/bridge-method-actions
Apr 7, 2026
Merged

chore: Update bridge controllers to expose all methods through messenger#8367
Mrtenz merged 8 commits intomainfrom
mrtenz/bridge-method-actions

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented Apr 2, 2026

Explanation

This updates the following controllers to expose all methods through the messenger in a standardised way:

  • BridgeController.
  • BridgeStatusController.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: changes are limited to new TypeScript action type exports, a build-time generation script dependency, and test refactoring; no bridge runtime logic is modified.

Overview
Adds an auto-generated bridge-controller-method-action-types.ts that defines and exports per-method messenger action types (e.g., BridgeControllerFetchQuotesAction) for all public BridgeController methods, and documents/deprecates the older aggregated action types in the changelog.

Updates package.json to support generating these types via a new generate-method-action-types script (adding tsx), and refactors the BridgeController SSE tests to exercise the controller through a real @metamask/messenger instance (rootMessenger.call(...)) instead of a hand-rolled messenger mock.

Written by Cursor Bugbot for commit 56740c7. This will update automatically on new commits. Configure here.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 2, 2026

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@Mrtenz Mrtenz force-pushed the mrtenz/bridge-method-actions branch from 0377135 to 0aa1851 Compare April 2, 2026 09:58
@Mrtenz Mrtenz marked this pull request as ready for review April 2, 2026 10:18
@Mrtenz Mrtenz requested review from a team as code owners April 2, 2026 10:18
@Mrtenz Mrtenz enabled auto-merge April 7, 2026 10:40
@Mrtenz Mrtenz added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit d6ce6e1 Apr 7, 2026
332 checks passed
@Mrtenz Mrtenz deleted the mrtenz/bridge-method-actions branch April 7, 2026 17:09
micaelae pushed a commit that referenced this pull request Apr 7, 2026
…ger (#8367)

This updates the following controllers to expose all methods through the
messenger in a standardised way:

- `BridgeController`.
- `BridgeStatusController`.

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: changes are limited to new TypeScript action type exports, a
build-time generation script dependency, and test refactoring; no bridge
runtime logic is modified.
>
> **Overview**
> Adds an auto-generated `bridge-controller-method-action-types.ts` that
defines and exports **per-method** messenger action types (e.g.,
`BridgeControllerFetchQuotesAction`) for all public `BridgeController`
methods, and documents/deprecates the older aggregated action types in
the changelog.
>
> Updates `package.json` to support generating these types via a new
`generate-method-action-types` script (adding `tsx`), and refactors the
`BridgeController` SSE tests to exercise the controller through a real
`@metamask/messenger` instance (`rootMessenger.call(...)`) instead of a
hand-rolled messenger mock.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
56740c7. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants