feat(STX-433): add submissionMethod to transaction metadata#8375
Merged
rarquevaux merged 2 commits intomainfrom Apr 7, 2026
Merged
feat(STX-433): add submissionMethod to transaction metadata#8375rarquevaux merged 2 commits intomainfrom
rarquevaux merged 2 commits intomainfrom
Conversation
rarquevaux
force-pushed
the
feat/STX-433-metadata
branch
from
7b11078 to
221177a
Compare
vinistevam
reviewed
Apr 7, 2026
| /** | ||
| * The method used to submit the transaction to the network. | ||
| */ | ||
| submissionMethod?: TransactionSubmissionMethod; |
Contributor
There was a problem hiding this comment.
nit: sort alphabetically
vinistevam
approved these changes
Apr 7, 2026
micaelae
pushed a commit
that referenced
this pull request
Apr 7, 2026
## Explanation The goal of this PR is to add a `submissionMethod` property in the TransactionMetadata object in order to record how the transaction was submitted to the network and add it to the metrics. This datapoint can be recording at submission in the https://github.com/MetaMask/metamask-extension/blob/main/app/scripts/controller-init/confirmations/transaction-controller-init.ts Draft PR on extension to demonstrate the use case: MetaMask/metamask-extension#41465 <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this is a type-only change adding an optional metadata field and enum export, with no behavioral changes to transaction processing. > > **Overview** > Adds an optional `submissionMethod` field to `TransactionMeta` along with a new `TransactionSubmissionMethod` enum (currently `sentinel_stx` and `sentinel_relay`) so clients can persist how a transaction was submitted. > > Re-exports `TransactionSubmissionMethod` from the package entrypoint and documents the addition in the `transaction-controller` changelog. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit dd12d37. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The goal of this PR is to add a
submissionMethodproperty in the TransactionMetadata object in order to record how the transaction was submitted to the network and add it to the metrics. This datapoint can be recording at submission in the https://github.com/MetaMask/metamask-extension/blob/main/app/scripts/controller-init/confirmations/transaction-controller-init.tsReferences
Checklist
Note
Low Risk
Low risk: this is a type-only change adding an optional metadata field and enum export, with no behavioral changes to transaction processing.
Overview
Adds an optional
submissionMethodfield toTransactionMetaalong with a newTransactionSubmissionMethodenum (currentlysentinel_stxandsentinel_relay) so clients can persist how a transaction was submitted.Re-exports
TransactionSubmissionMethodfrom the package entrypoint and documents the addition in thetransaction-controllerchangelog.Reviewed by Cursor Bugbot for commit dd12d37. Bugbot is set up for automated code reviews on this repo. Configure here.