Conversation
…ster asset loading - Split getAssets pipeline into a fast awaited path (AccountsApi + StakedBalance) and a parallel background path (Snap + RPC) to reduce perceived latency on unlock and onboarding - Batch PriceDataSource and TokenDataSource API requests in chunks of 50 using reduceInBatchesSerially to avoid DynamoDB 100-item batch limit errors - Filter synthetic slip44:NUMBER-* staking-position asset IDs from Price API calls - Filter EVM ERC-20 tokens by occurrences >= 3 (treat missing occurrences as 0) - Fix ESLint "in" operator violation in PriceDataSource isValidMarketData`
salimtb
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 32d17b5. Configure here.
bergarces
reviewed
Apr 7, 2026
| // number (e.g. slip44:195-ready-for-withdrawal, slip44:195-in-lock-period, | ||
| // slip44:195-staking-rewards, slip44:195-staked-for-…) is a MetaMask-internal | ||
| // synthetic asset that has no market price. | ||
| /\/slip44:\d+-/u, |
Contributor
There was a problem hiding this comment.
If we want to match and exclude anything that has a non-numeric value after /slip44:, we could use /\/slip44:.*\D/u.
That will cover anything that has a non-numeric value in any position.
Are there any assets that have non-numeric values and we do not want to exclude? Because otherwise, we no longer need the Tron exceptions.
Suggested change
| /\/slip44:\d+-/u, | |
| /\/slip44:.*\D/u, |
bergarces
reviewed
Apr 7, 2026
| // | ||
| // Both the fast and background pipelines use 'merge' mode because neither | ||
| // alone represents the full set of data sources. Using 'full' in either | ||
| // would wipe balances from the sources handled by the other pipeline. |
Contributor
There was a problem hiding this comment.
Are we going to need a full wipe at some point? Or is that something we can live without?
Contributor
Author
There was a problem hiding this comment.
i think we can live without , the old controllers was following this logic
bergarces
reviewed
Apr 7, 2026
|
|
||
| if (!this.#isBasicFunctionality()) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Good catch.
Not for this PR, but maybe we should move the basic functionality check to the data source fetching itself, that way we don't need to keep guessing if something can or can't be done at this level.
bergarces
approved these changes
Apr 7, 2026
salimtb
deleted the
feat/assets-controller-pipeline-batching-optimization
branch
salimtb
added a commit
that referenced
this pull request
Apr 7, 2026
micaelae
pushed a commit
that referenced
this pull request
Apr 7, 2026
…ster asset loading (#8383) - Split getAssets pipeline into a fast awaited path (AccountsApi + StakedBalance) and a parallel background path (Snap + RPC) to reduce perceived latency on unlock and onboarding - Batch PriceDataSource and TokenDataSource API requests in chunks of 50 using reduceInBatchesSerially to avoid DynamoDB 100-item batch limit errors - Filter synthetic slip44:NUMBER-* staking-position asset IDs from Price API calls - Filter EVM ERC-20 tokens by occurrences >= 3 (treat missing occurrences as 0) - Fix ESLint "in" operator violation in PriceDataSource isValidMarketData` ## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes core asset-loading flow to run RPC/Snap in a fire-and-forget background pipeline and alters token/price enrichment behavior (especially in RPC-only mode), which could affect state consistency and displayed balances/prices if regressions occur. > > **Overview** > **Speeds up perceived asset loading** by splitting `AssetsController.getAssets` into an awaited *fast* pipeline (Accounts API + staked balance → detection → token/price) and a *background* Snap/RPC pipeline that merges results into state asynchronously. > > **Tightens RPC-only behavior**: when basic functionality is disabled, token/price enrichment is skipped in both `getAssets` and `handleAssetsUpdate`, and `setSelectedCurrency` no longer triggers a price refresh. > > **Reduces backend/API failure risk** by batching `PriceDataSource` spot-price requests and `TokenDataSource` metadata requests into chunks of 50, and by filtering synthetic `slip44:<number>-*` staking-position asset IDs out of Price API calls; token spam filtering is updated to require `occurrences >= 3` for EVM ERC-20s (missing treated as 0) while non-EVM `token` assets continue to use Blockaid. Tests/changelog are updated accordingly. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 32d17b5. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes core asset-loading flow to run RPC/Snap in a fire-and-forget background pipeline and alters token/price enrichment behavior (especially in RPC-only mode), which could affect state consistency and displayed balances/prices if regressions occur.
Overview
Speeds up perceived asset loading by splitting
AssetsController.getAssetsinto an awaited fast pipeline (Accounts API + staked balance → detection → token/price) and a background Snap/RPC pipeline that merges results into state asynchronously.Tightens RPC-only behavior: when basic functionality is disabled, token/price enrichment is skipped in both
getAssetsandhandleAssetsUpdate, andsetSelectedCurrencyno longer triggers a price refresh.Reduces backend/API failure risk by batching
PriceDataSourcespot-price requests andTokenDataSourcemetadata requests into chunks of 50, and by filtering syntheticslip44:<number>-*staking-position asset IDs out of Price API calls; token spam filtering is updated to requireoccurrences >= 3for EVM ERC-20s (missing treated as 0) while non-EVMtokenassets continue to use Blockaid. Tests/changelog are updated accordingly.Reviewed by Cursor Bugbot for commit 32d17b5. Bugbot is set up for automated code reviews on this repo. Configure here.