Skip to content

fix(assets-controller): hardened error handling#8389

Merged
Kriys94 merged 1 commit into
mainfrom
fix/TryCatch2
Apr 7, 2026
Merged

fix(assets-controller): hardened error handling#8389
Kriys94 merged 1 commit into
mainfrom
fix/TryCatch2

Conversation

@Kriys94
Copy link
Copy Markdown
Contributor

@Kriys94 Kriys94 commented Apr 7, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Moderate risk because it changes how balance/detection/staked-balance update callbacks propagate failures, potentially masking bugs but preventing unhandled rejections from breaking polling ticks or subscriptions.

Overview
Improves resilience of assets-controller update pipelines by catching and logging errors inside subscription/polling callbacks instead of letting them throw/reject.

AssetsController now guards onActiveChainsUpdated, and RpcDataSource/StakedBalanceDataSource wrap balance, detection, and staked-balance update handlers so poll ticks can’t fail due to uncaught exceptions or unhandled promise rejections.

Reviewed by Cursor Bugbot for commit db04572. Bugbot is set up for automated code reviews on this repo. Configure here.

@Kriys94 Kriys94 marked this pull request as ready for review April 7, 2026 13:47
@Kriys94 Kriys94 requested a review from a team as a code owner April 7, 2026 13:47
@Kriys94 Kriys94 added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 23c22bd Apr 7, 2026
342 of 343 checks passed
@Kriys94 Kriys94 deleted the fix/TryCatch2 branch April 7, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants