fix(assets-controller): hardened error handling#8389
Merged
Conversation
bergarces
approved these changes
Apr 7, 2026
salimtb
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Moderate risk because it changes how balance/detection/staked-balance update callbacks propagate failures, potentially masking bugs but preventing unhandled rejections from breaking polling ticks or subscriptions.
Overview
Improves resilience of
assets-controllerupdate pipelines by catching and logging errors inside subscription/polling callbacks instead of letting them throw/reject.AssetsControllernow guardsonActiveChainsUpdated, andRpcDataSource/StakedBalanceDataSourcewrap balance, detection, and staked-balance update handlers so poll ticks can’t fail due to uncaught exceptions or unhandled promise rejections.Reviewed by Cursor Bugbot for commit db04572. Bugbot is set up for automated code reviews on this repo. Configure here.