feat(social-controllers): add intent and category fields to Trade type#8410
Open
feat(social-controllers): add intent and category fields to Trade type#8410
Conversation
Add `intent` ("enter" | "exit") as the preferred alternative to the
semi-deprecated `direction` field, and `category` (optional) to
distinguish trade types (e.g. "receive" for airdrops/transfers).
TSA-371
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 624ed68. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Add
intent("enter" | "exit") as the preferred alternative to the semi-deprecateddirectionfield, andcategory(optional) to distinguish trade types (e.g. "receive" for airdrops/transfers).TSA-371
References
Checklist
Note
Medium Risk
Updates the
Tradecontract and superstruct validation to require a newintentfield and restrictdirection/intentto enums, which may break consumers or reject older API responses that don’t include these fields.Overview
Extends the
Trademodel to include requiredintent('enter' | 'exit') and optionalcategory, and narrowsdirectionto'buy' | 'sell'.Moves the trade validation schema into
social-typesas exportedTradeStruct, derivesTradeviaInfer, and updatesSocialServiceposition validation and tests to use the new schema.Reviewed by Cursor Bugbot for commit 3ba3a5a. Bugbot is set up for automated code reviews on this repo. Configure here.