Conversation
Jwhiles
force-pushed
the
add-chomp-api
branch
4 times, most recently
from
8b1785b to
be04334
Compare
mcmire
reviewed
Apr 10, 2026
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
This looks pretty good so far! I just had a few comments.
| }); | ||
|
|
||
| this.#baseUrl = baseUrl; | ||
| this.#getAccessToken = getAccessToken; |
Contributor
There was a problem hiding this comment.
Where will this access token come from in the clients? Will this come from another controller or service? If so, then it would be better to use the messenger to retrieve this value instead of taking a callback.
Contributor
Author
MoMannn
reviewed
Apr 13, 2026
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Contributor
Author
|
@metamaskbot publish-preview |
Jwhiles
force-pushed
the
add-chomp-api
branch
2 times, most recently
from
0e8c506 to
08b3d87
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Jwhiles
force-pushed
the
add-chomp-api
branch
5 times, most recently
from
039faf6 to
2f413ac
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a820fad. Configure here.
MoMannn
requested changes
Apr 17, 2026
MoMannn
previously approved these changes
Apr 17, 2026
shane-t
previously approved these changes
Apr 17, 2026
mcmire
previously approved these changes
Apr 17, 2026
shane-t
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
In this PR we create an API client to allow our client applications to use the chomp API. It fixes this ticket
References
Checklist
Note
Medium Risk
Introduces a new authenticated HTTP client/service that fetches JWT bearer tokens via messenger and performs write operations against an external API, so incorrect request/response handling could impact downstream flows but existing packages are largely untouched.
Overview
Adds a new
@metamask/chomp-api-servicepackage implementingChompApiService(aBaseDataService) to call the CHOMP API with JWT bearer auth sourced fromAuthenticationController:getBearerToken.The service exposes messenger-callable methods for address association, account upgrade create/get, delegation verification, intent create/list, withdrawal creation, and service-details lookup, with runtime response validation via
superstruct, explicit status handling (e.g.,409/404), and comprehensivenock-based tests.Repo wiring is updated to include the new package in TypeScript project references, the monorepo README package list/graph,
CODEOWNERS/teams.json, andyarn.lock.Reviewed by Cursor Bugbot for commit 0b15c9f. Bugbot is set up for automated code reviews on this repo. Configure here.