fix: set submittedTime at pay publish hook start for accurate time-to-complete metrics

[dan437]

Explanation

For intent-based flows (e.g., perps withdrawals via Hyperliquid + Relay), the entire Relay execution happens inside TransactionPayPublishHook. TransactionController only sets submittedTime after the publish hook returns, which means submittedTime is nearly identical to the finalization time. This causes mm_pay_time_to_complete_s to report ~0.5s instead of the actual seconds/minutes it takes.

transaction-pay-controller: TransactionPayPublishHook now sets submittedTime on the transaction at the start of the hook (before strategy.execute), capturing the moment the user initiates the action.

transaction-controller: submittedTime assignment in #approveTransaction changed from = to ??= so it preserves a value pre-set by the publish hook. Normal flows where submittedTime is not pre-set are unaffected.

References

• CONF-1158
• Related to fix: mm_pay_time_to_complete_s is logging incorrect (too low) values metamask-mobile#27862

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Low Risk
Low risk behavioral tweak to transaction metadata timestamping; main risk is subtle impact on metrics or downstream assumptions about when submittedTime is set.

Overview
Improves intent-based MetaMask Pay timing metrics by setting submittedTime at the start of TransactionPayPublishHook (before strategy.execute) when quotes exist, rather than effectively at the end of the pay strategy.

Updates TransactionController to preserve any pre-set submittedTime (e.g., set by a publish hook) by using nullish assignment when marking a transaction as submitted, and adds targeted tests plus changelog entries to cover the new behavior.

^{Reviewed by Cursor Bugbot for commit 5907d59. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit db54890. Configure here.}