chore: add imageUrl

[joaosantos15]

Explanation

Add tokenImageUrl to Position and avgHoldMinutes to TraderStats types and superstruct schemas so the extension can consume the new API fields. Also fixes fetchClosedPositions hitting a v2 URL that doesn't exist (the closed positions endpoint is v1-only), which was causing 404s.

References

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Medium Risk
Touches social API response validation/types and changes the fetchClosedPositions URL selection, which could affect consumers if the API payloads or endpoints differ from assumptions. Scope is limited to @metamask/social-controllers with updated tests covering the new fields and endpoint.

Overview
Adds support for new social-api response fields by extending Position/PositionStruct with optional tokenImageUrl and TraderStats/TraderStatsStruct with optional medianHoldMinutes.

Fixes fetchClosedPositions to call the v1 closed-positions endpoint (while keeping open positions on v2) to avoid 404s, and updates tests/changelog accordingly.

^{Reviewed by Cursor Bugbot for commit b1fc8cb. Bugbot is set up for automated code reviews on this repo. Configure here.}

[Bigshmow]

Just a note on median vs mean, otherwise LGTM.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b1fc8cb. Configure here.}

[cursor]

Schema field name likely mismatches API response key

Medium Severity

The PR discussion states the backend API (clicker) returns medianHoldingTimeMinutes, but the superstruct schema and TraderStats type both define the field as medianHoldMinutes. Since superstruct's type() matches on exact key names and this field is optional(nullable(...)), validation silently passes even though the key is absent — meaning medianHoldMinutes will always be undefined at runtime, and the actual API value under medianHoldingTimeMinutes is silently discarded.

Additional Locations (1)

• packages/social-controllers/src/social-types.ts#L107-L109

 

^{Reviewed by Cursor Bugbot for commit b1fc8cb. Configure here.}