fix: Fix batch transaction_type in metrics for pay transactions#8469
Merged
fix: Fix batch transaction_type in metrics for pay transactions#8469
batch transaction_type in metrics for pay transactions#8469Conversation
Member
Author
|
@metamaskbot publish-preview |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
matthewwalsh0
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Resolve the effective transaction type from
nestedTransactionswhen the parent is a batch transaction, so relay deposits for mUSD conversions (and other supported types) are correctly classified even when batched.Result of transaction metrics in mobile with preview build:
References
Checklist
Note
Medium Risk
Changes how relay deposit transactions are typed when the parent transaction is
batch, which can affect metrics and downstream type-based handling. Adds a newTransactionTypeenum value that consumers may need to recognize.Overview
Fixes MetaMask Pay relay submissions so relay deposit transactions are typed based on the underlying nested transaction when the parent is
TransactionType.batch, rather than always using the top-levelbatchtype.Adds a new
TransactionType.musdRelayDepositand mapsmusdConversion -> musdRelayDepositinRELAY_DEPOSIT_TYPES, with expanded unit tests covering batch/nested resolution and fallback behavior. Changelogs are updated for bothtransaction-controllerandtransaction-pay-controller.Reviewed by Cursor Bugbot for commit dcb47ad. Bugbot is set up for automated code reviews on this repo. Configure here.