Skip to content

feat: added money-account-balance-service to root tsconfig files#8477

Merged
Matt561 merged 3 commits intomainfrom
chore/adding-money-account-balance-service-to-root-ts-config
Apr 15, 2026
Merged

feat: added money-account-balance-service to root tsconfig files#8477
Matt561 merged 3 commits intomainfrom
chore/adding-money-account-balance-service-to-root-ts-config

Conversation

@Matt561
Copy link
Copy Markdown
Contributor

@Matt561 Matt561 commented Apr 15, 2026

Explanation

Add @metamask/money-account-balance-service to the root tsconfig.json and tsconfig.build.json files.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Only updates TypeScript project references and changelog; no runtime or business-logic behavior changes.

Overview
Adds packages/money-account-balance-service to the root tsconfig.json and tsconfig.build.json project references, making it included in repo-wide TypeScript linting/editor tooling and in the aggregated build.

Updates packages/money-account-balance-service/CHANGELOG.md under Unreleased to document the new root tsconfig inclusion.

Reviewed by Cursor Bugbot for commit bda9a4d. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c38466f. Configure here.

Comment thread tsconfig.json
@Matt561 Matt561 requested a review from mcmire April 15, 2026 21:50
@mcmire
Copy link
Copy Markdown
Contributor

mcmire commented Apr 15, 2026

@Matt561 Should we also include an entry in the changelog for the package, since this fixes the package so it's usable now?

@Matt561 Matt561 requested review from a team as code owners April 15, 2026 22:11
@Matt561
Copy link
Copy Markdown
Contributor Author

Matt561 commented Apr 15, 2026

@Matt561 Should we also include an entry in the changelog for the package, since this fixes the package so it's usable now?

Good idea. I've updated the changelog 👍

@Matt561 Matt561 enabled auto-merge April 15, 2026 22:19
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by running yarn build. The dist directory in money-account-balance-service now exists and has the correct files. LGTM.

@Matt561 Matt561 added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 360a80d Apr 15, 2026
345 checks passed
@Matt561 Matt561 deleted the chore/adding-money-account-balance-service-to-root-ts-config branch April 15, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants