Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
bergarces
force-pushed
the
native-asset-detection
branch
from
a7ae91d to
f57ddeb
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
salimtb
reviewed
Apr 22, 2026
| AccountTreeControllerStateChangeEvent, | ||
| } from '@metamask/account-tree-controller'; | ||
| import type { AccountsControllerGetSelectedAccountAction } from '@metamask/accounts-controller'; | ||
| import { SPOT_PRICES_SUPPORT_INFO } from '@metamask/assets-controllers'; |
Contributor
There was a problem hiding this comment.
hmmm do we need to release first the assets-controllers and bump it inside this package ?
Contributor
Author
There was a problem hiding this comment.
Can be done at the same time when we release. It's a minor release for both packages as there are no breaking changes.
salimtb
previously approved these changes
Apr 22, 2026
Prithpal-Sooriya
previously approved these changes
Apr 22, 2026
bergarces
dismissed stale reviews from Prithpal-Sooriya and salimtb
via
b23b2a4
bergarces
force-pushed
the
native-asset-detection
branch
from
2ba0a4e to
6a3d9ce
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
salimtb
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The code for the new controller currently considers that only assets in the slip44 namespace are native. This limits support for prices on many chains supported by price-api. With this changes, we create a centralised way of determining if an asset is native, as well as support chains for which price-api does not yet support the slip44 entry or for which there is none.
Not doing this would cause a regression when the new controller is updated.
With AssetsController enabled without this changes, we are missing support for chains that already had support before. Mostly due to using a wrong default instead of a specific assetId.
References
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2885
Checklist
Note
Medium Risk
Touches native-asset identification used by balance fetching, token metadata filtering, and bridge/transaction-pay formatting, so misclassification could impact displayed balances/prices across chains. Changes are well-covered by updated and new unit tests, reducing but not eliminating regression risk.
Overview
Fixes native-asset detection by introducing a cached chainId→native-asset map (seeded from
SPOT_PRICES_SUPPORT_INFOand optionally augmented viachainid.network) and using it throughoutAssetsControllerand data sources instead of relying onslip44:namespace checks.Updates EVM balance/price/token flows to treat native assets consistently even when represented as ERC-20 (e.g., zero-address forms), including passing native-asset resolvers into
RpcDataSource,BalanceFetcher, andBackendWebsocketDataSource, and updatingformatExchangeRatesForBridge/formatStateForTransactionPayto derive native handling fromassetsInfoandgetNativeTokenAddress.Reviewed by Cursor Bugbot for commit af2c9f6. Bugbot is set up for automated code reviews on this repo. Configure here.