feat: adds auth to social controllers#8485
Merged
joaosantos15 merged 6 commits intomainfrom Apr 16, 2026
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
zone-live
approved these changes
Apr 16, 2026
xavier-brochard
approved these changes
Apr 16, 2026
geositta
added a commit
that referenced
this pull request
Apr 16, 2026
…sition-live-price-sync * origin/main: fix(transaction-pay-controller): resolve correct networkClientId for source chain in relay execute (#8492) Release/920.0.0 (#8494) chore: bump `accounts` deps (#8464) feat: adds auth to social controllers (#8485) Release/919.0.0 (#8482) feat(seedless-onboarding-controller): generic encryptor result type aligned with KeyringController TO-686 (#8411) Release/918.0.0 (#8478) chore: add periodic check for spl tokens (#8400)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently requests to the Social API are unauthenticated. This was useful during the development phase but as we near prod deployment, we need to protect the endpoints, this PR does that:
References
Checklist
Note
Medium Risk
Introduces a breaking messenger dependency and changes every outgoing Social API request to include auth headers, which can cause runtime failures if token delegation is missing or tokens are invalid/expired.
Overview
SocialServicenow authenticates all Social API requests by fetching a JWT via messenger (AuthenticationController:getBearerToken) and sending it as aBearerAuthorizationheader on everyfetch*/follow/unfollowcall.This introduces a breaking messenger contract change:
SocialServiceMessenger’s allowed actions now includeAuthenticationController:getBearerToken, requiring consumers to delegate/provide that action; the package adds@metamask/profile-sync-controller(type dependency) and updates tests/build references accordingly.Reviewed by Cursor Bugbot for commit e6837da. Bugbot is set up for automated code reviews on this repo. Configure here.