Merged
Conversation
| "@metamask/account-tree-controller": "^7.1.0", | ||
| "@metamask/accounts-controller": "^37.2.0", | ||
| "@metamask/assets-controllers": "^104.0.0", | ||
| "@metamask/assets-controllers": "^104.1.0", |
Contributor
Author
There was a problem hiding this comment.
Dependency bump.
| { | ||
| "name": "@metamask/assets-controllers", | ||
| "version": "104.0.0", | ||
| "version": "104.1.0", |
Contributor
Author
There was a problem hiding this comment.
Main package release
| "@metamask/accounts-controller": "^37.2.0", | ||
| "@metamask/assets-controller": "^6.0.0", | ||
| "@metamask/assets-controllers": "^104.0.0", | ||
| "@metamask/assets-controllers": "^104.1.0", |
Contributor
Author
There was a problem hiding this comment.
Dependency bump.
| "@ethersproject/providers": "^5.7.0", | ||
| "@metamask/assets-controller": "^6.0.0", | ||
| "@metamask/assets-controllers": "^104.0.0", | ||
| "@metamask/assets-controllers": "^104.1.0", |
Contributor
Author
There was a problem hiding this comment.
Dependency bump.
sahar-fehri
reviewed
Apr 17, 2026
bergarces
reviewed
Apr 17, 2026
Contributor
There was a problem hiding this comment.
There are a lot of changelog linting changes here. Is that expected?
Edit: They look mostly ok though, so not blocking for me. Just wondering.
Contributor
Author
There was a problem hiding this comment.
Changes was done by the yarn create-release-branch script. It fixed some areas, but also found some issues which are now resolved.
Comment on lines
+1707
to
+1709
| - **BREAKING:** Bump `@metamask/keyring-controller` peer dependency from `^18.0.0` to `^19.0.0` ([#4195](https://github.com/MetaMask/core/pull/4195)) | ||
| - **BREAKING:** Bump `@metamask/accounts-controller` peer dependency from `^19.0.0` to `^20.0.0` ([#4195](https://github.com/MetaMask/core/pull/4195)) | ||
| - **BREAKING:** Bump `@metamask/preferences-controller` peer dependency from `^14.0.0` to `^15.0.0` ([#4195](https://github.com/MetaMask/core/pull/4195)) |
Contributor
Author
There was a problem hiding this comment.
create-release-branch change.
This is incorrect, should be PR 4956
Comment on lines
+12
to
+15
| ### Uncategorized | ||
|
|
||
| - chore: Enable Oxfmt for generating method action types files ([#8498](https://github.com/MetaMask/core/pull/8498)) | ||
| - chore: Format changelogs with Oxfmt ([#8442](https://github.com/MetaMask/core/pull/8442)) |
Contributor
Author
There was a problem hiding this comment.
Should be removed.
create-release-branch had mostly corrected most of the changelog formatting. But has some issues that were highlighted and captured.
Contributor
Author
There was a problem hiding this comment.
Formatting changes on this file were done by create-release-branch (or a formatter ran on top of this). I've reviewed the changes made, but another pair of eyes would be great.
I've added resolved comments that you can open in some areas for this changelog.
|
|
||
| - Update token rate request key to handle when new tokens are detected inside the `TokenRatesController` ([#5531](https://github.com/MetaMask/core/pull/5311))) | ||
| - Update `CurrencyRateController` to prevent undefined or empty currencies from being queried ([#5458](https://github.com/MetaMask/core/pull/5458))) | ||
| - Update token rate request key to handle when new tokens are detected inside the `TokenRatesController`) ([#5531](https://github.com/MetaMask/core/pull/5531)) |
Contributor
Author
There was a problem hiding this comment.
TY script, this is correct now
Comment on lines
+1702
to
+1704
| - **BREAKING:** Bump `@metamask/keyring-controller` peer dependency from `^18.0.0` to `^19.0.0` ([#4956](https://github.com/MetaMask/core/pull/4956)) | ||
| - **BREAKING:** Bump `@metamask/accounts-controller` peer dependency from `^19.0.0` to `^20.0.0` ([#4956](https://github.com/MetaMask/core/pull/4956)) | ||
| - **BREAKING:** Bump `@metamask/preferences-controller` peer dependency from `^14.0.0` to `^15.0.0` ([#4956](https://github.com/MetaMask/core/pull/4956)) |
Contributor
Author
There was a problem hiding this comment.
Manually fixed. Link was correct, text needed fixing.
changelog:validate does not work well with our formatter.
bergarces
previously approved these changes
Apr 17, 2026
mcmire
reviewed
Apr 17, 2026
mcmire
previously approved these changes
Apr 17, 2026
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
One minor comment, but the release looks valid at least. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
@metamask/assets-controllersfrom "104.0.0" to"^104.1.0"References
Checklist
Note
Medium Risk
Primarily a version/dependency bump, but it pulls in
@metamask/assets-controllers@104.1.0which changes multichain asset scanning behavior (Blockaid re-scan and stricter fail-closed handling) and could affect token visibility/performance.Overview
Bumps the monorepo release version to
923.0.0and releases@metamask/assets-controllersas104.1.0.Updates downstream packages (
assets-controller,bridge-controller,transaction-pay-controller) to depend on@metamask/assets-controllers@^104.1.0, updatesyarn.lock, and records the bump in the affected changelogs (including the new104.1.0entry).Reviewed by Cursor Bugbot for commit 0ceb172. Bugbot is set up for automated code reviews on this repo. Configure here.