Skip to content

feat: updated character length to 3 for ENS controller#8510

Merged
NidhiKJha merged 4 commits intomainfrom
update-ens-character-length
Apr 30, 2026
Merged

feat: updated character length to 3 for ENS controller#8510
NidhiKJha merged 4 commits intomainfrom
update-ens-character-length

Conversation

@NidhiKJha
Copy link
Copy Markdown
Member

@NidhiKJha NidhiKJha commented Apr 17, 2026

Explanation

This PR is to update ens character length from 7 in regex to 3

Fixes: issue

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Changes input validation for ENS names, which can affect what names are accepted/stored across controllers; logic change is small but broadens allowed inputs and could surface edge-case name handling differences.

Overview
ENS name validation is loosened by updating normalizeEnsName to accept .eth/.test names where the final label is 3+ characters (previously 7+), enabling shorter ENS registrations to be stored and resolved.

Tests are updated to reflect the new minimum length, including coverage that EnsController.set now accepts foo.eth and that multi-level names like foo.barbaz.eth are no longer rejected purely for length; the controller-utils changelog is updated accordingly.

Reviewed by Cursor Bugbot for commit 07d92fd. Bugbot is set up for automated code reviews on this repo. Configure here.

@NidhiKJha NidhiKJha requested review from a team as code owners April 17, 2026 14:46
Comment thread packages/controller-utils/src/util.ts
@NidhiKJha NidhiKJha enabled auto-merge April 30, 2026 10:15
@NidhiKJha NidhiKJha added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit 034d10b Apr 30, 2026
366 checks passed
@NidhiKJha NidhiKJha deleted the update-ens-character-length branch April 30, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants