fix(transaction-pay-controller): proxy Across status polling via configured api base#8512
Merged
pedronfigueiredo merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
df5a7ef to
c5e3add
Compare
4 tasks
c5e3add to
2c73a02
Compare
dan437
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apiBaseinstead of the direct upstream URLdepositTxnRefand acceptfillTxnRefas a terminal transaction hash fallbackconfirmations_payfrom remote feature flags or local overrides, and usehttp://localhost:3000/acrosswhenconfirmations_pay.devis enabled without an explicit Across baseValidation
yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/strategy/across/across-submit.test.ts src/utils/feature-flags.test.tsyarn eslint packages/transaction-pay-controller/src/strategy/across/across-submit.ts packages/transaction-pay-controller/src/strategy/across/across-submit.test.ts packages/transaction-pay-controller/src/utils/feature-flags.ts packages/transaction-pay-controller/src/utils/feature-flags.test.tsyarn workspace @metamask/transaction-pay-controller run changelog:validateyarn buildNote
Medium Risk
Touches Across bridging completion logic and status polling parameters/base URL; misconfiguration or unexpected API response shapes could cause submissions to appear stuck or resolve to the wrong final hash.
Overview
Across submission now polls the
/deposit/statusendpoint via the configuredconfirmations_pay.payStrategies.across.apiBase(instead of relying on quote-provided/upstream URL details) and uses the source transaction hash asdepositTxnRef.Status completion handling is updated to accept
fillTxnRefas an additional terminal transaction hash fallback (beforefillTxHash/txHash). Tests are adjusted/added to assert the new polling URL/params and hash fallback behavior, and the changelog documents the fix.Reviewed by Cursor Bugbot for commit 2c73a02. Bugbot is set up for automated code reviews on this repo. Configure here.