Skip to content

fix(transaction-pay-controller): proxy Across status polling via configured api base#8512

Merged
pedronfigueiredo merged 1 commit intomainfrom
pnf/tpc-proxy-across-status-via-intents
Apr 20, 2026
Merged

fix(transaction-pay-controller): proxy Across status polling via configured api base#8512
pedronfigueiredo merged 1 commit intomainfrom
pnf/tpc-proxy-across-status-via-intents

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented Apr 17, 2026

Summary

  • route Across status polling through the configured Across apiBase instead of the direct upstream URL
  • poll Across deposit status with depositTxnRef and accept fillTxnRef as a terminal transaction hash fallback
  • read confirmations_pay from remote feature flags or local overrides, and use http://localhost:3000/across when confirmations_pay.dev is enabled without an explicit Across base
  • add focused tests and changelog coverage for the new behavior

Validation

  • yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/strategy/across/across-submit.test.ts src/utils/feature-flags.test.ts
  • yarn eslint packages/transaction-pay-controller/src/strategy/across/across-submit.ts packages/transaction-pay-controller/src/strategy/across/across-submit.test.ts packages/transaction-pay-controller/src/utils/feature-flags.ts packages/transaction-pay-controller/src/utils/feature-flags.test.ts
  • yarn workspace @metamask/transaction-pay-controller run changelog:validate
  • yarn build

Note

Medium Risk
Touches Across bridging completion logic and status polling parameters/base URL; misconfiguration or unexpected API response shapes could cause submissions to appear stuck or resolve to the wrong final hash.

Overview
Across submission now polls the /deposit/status endpoint via the configured confirmations_pay.payStrategies.across.apiBase (instead of relying on quote-provided/upstream URL details) and uses the source transaction hash as depositTxnRef.

Status completion handling is updated to accept fillTxnRef as an additional terminal transaction hash fallback (before fillTxHash/txHash). Tests are adjusted/added to assert the new polling URL/params and hash fallback behavior, and the changelog documents the fix.

Reviewed by Cursor Bugbot for commit 2c73a02. Bugbot is set up for automated code reviews on this repo. Configure here.

@pedronfigueiredo pedronfigueiredo requested review from a team as code owners April 17, 2026 16:35
@pedronfigueiredo pedronfigueiredo self-assigned this Apr 17, 2026
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/tpc-proxy-across-status-via-intents branch 2 times, most recently from df5a7ef to c5e3add Compare April 17, 2026 16:56
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/tpc-proxy-across-status-via-intents branch from c5e3add to 2c73a02 Compare April 20, 2026 10:16
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit d8067bb Apr 20, 2026
350 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/tpc-proxy-across-status-via-intents branch April 20, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants