Skip to content

chore: add profileId to position response#8576

Merged
joaosantos15 merged 2 commits intomainfrom
TSA-443-core
Apr 24, 2026
Merged

chore: add profileId to position response#8576
joaosantos15 merged 2 commits intomainfrom
TSA-443-core

Conversation

@joaosantos15
Copy link
Copy Markdown
Contributor

@joaosantos15 joaosantos15 commented Apr 24, 2026

Explanation

Add profileId to position response.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: this is a type/response-validation schema expansion for positions plus test fixture updates, with no behavioral or endpoint changes. Main risk is consumers now needing to include positionId in mocked/expected position payloads to pass validation.

Overview
Positions returned by SocialService now require a new positionId field via updates to the Position type and the PositionStruct superstruct schema.

Tests and the package changelog are updated accordingly to reflect and validate the new field.

Reviewed by Cursor Bugbot for commit 27e303a. Bugbot is set up for automated code reviews on this repo. Configure here.

@joaosantos15 joaosantos15 marked this pull request as ready for review April 24, 2026 11:09
@joaosantos15 joaosantos15 requested review from a team as code owners April 24, 2026 11:09
@joaosantos15 joaosantos15 enabled auto-merge April 24, 2026 11:23
@joaosantos15 joaosantos15 added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit 4e31b2f Apr 24, 2026
358 checks passed
@joaosantos15 joaosantos15 deleted the TSA-443-core branch April 24, 2026 12:13
@joaosantos15
Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants