chore: add profileId to position response#8576
Merged
joaosantos15 merged 2 commits intomainfrom Apr 24, 2026
Merged
Conversation
xavier-brochard
approved these changes
Apr 24, 2026
Contributor
Author
|
@metamaskbot publish-preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add profileId to position response.
References
Checklist
Note
Low Risk
Low risk: this is a type/response-validation schema expansion for positions plus test fixture updates, with no behavioral or endpoint changes. Main risk is consumers now needing to include
positionIdin mocked/expected position payloads to pass validation.Overview
Positions returned by
SocialServicenow require a newpositionIdfield via updates to thePositiontype and thePositionStructsuperstruct schema.Tests and the package changelog are updated accordingly to reflect and validate the new field.
Reviewed by Cursor Bugbot for commit 27e303a. Bugbot is set up for automated code reviews on this repo. Configure here.