Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c47a59d. Configure here.
…adata.enabled support
c47a59d to
9fb82b2
Compare
hmalik88
previously approved these changes
Apr 28, 2026
salimtb
previously approved these changes
Apr 28, 2026
aganglada
previously approved these changes
Apr 28, 2026
jiexi
previously approved these changes
Apr 28, 2026
ffmcgee725
previously approved these changes
Apr 28, 2026
hmalik88
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Bumping
accountsdeps and re-adapt usage ofInternalAccount.metadata.snap.{enabled,name}.References
N/A
Checklist
Note
Medium Risk
This is a breaking change that removes persisted Snap enablement/name fields from
InternalAccount.metadata.snapand changes how Snap accounts are classified/grouped based on liveSnapController:getSnapdata. It also bumps multiple keyring-related dependencies, which can introduce subtle runtime or type-level behavior changes across consumers.Overview
Breaking Snap metadata change:
InternalAccount.metadata.snap.{enabled,name}is removed, and snap enablement/blocked status is now determined viaSnapController:getSnapinstead of account metadata.Account grouping behavior change:
account-tree-controller’sSnapRulenow only matches accounts whose snap is present,enabled, and notblocked; if the snap is missing/unavailable, those accounts fall back to the keyring rule (with updated tests asserting the new grouping/name).Dependency bumps/cleanup: bumps
@metamask/keyring-internal-apito^11.0.0,@metamask/eth-snap-keyringto^22.0.0,@metamask/eth-hd-keyringto^14.1.0, and@metamask/eth-money-keyringto^2.0.3, and removesaccounts-controller’s dependency onsnaps-*packages and theSnapController:stateChangesubscription (plus related tests).Reviewed by Cursor Bugbot for commit a4a9db3. Bugbot is set up for automated code reviews on this repo. Configure here.