Skip to content

chore!: bump accounts deps#8584

Merged
ccharly merged 13 commits intomainfrom
cc/chore/bump-accounts-deps
Apr 28, 2026
Merged

chore!: bump accounts deps#8584
ccharly merged 13 commits intomainfrom
cc/chore/bump-accounts-deps

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Apr 27, 2026

Explanation

Bumping accounts deps and re-adapt usage of InternalAccount.metadata.snap.{enabled,name}.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
This is a breaking change that removes persisted Snap enablement/name fields from InternalAccount.metadata.snap and changes how Snap accounts are classified/grouped based on live SnapController:getSnap data. It also bumps multiple keyring-related dependencies, which can introduce subtle runtime or type-level behavior changes across consumers.

Overview
Breaking Snap metadata change: InternalAccount.metadata.snap.{enabled,name} is removed, and snap enablement/blocked status is now determined via SnapController:getSnap instead of account metadata.

Account grouping behavior change: account-tree-controller’s SnapRule now only matches accounts whose snap is present, enabled, and not blocked; if the snap is missing/unavailable, those accounts fall back to the keyring rule (with updated tests asserting the new grouping/name).

Dependency bumps/cleanup: bumps @metamask/keyring-internal-api to ^11.0.0, @metamask/eth-snap-keyring to ^22.0.0, @metamask/eth-hd-keyring to ^14.1.0, and @metamask/eth-money-keyring to ^2.0.3, and removes accounts-controller’s dependency on snaps-* packages and the SnapController:stateChange subscription (plus related tests).

Reviewed by Cursor Bugbot for commit a4a9db3. Bugbot is set up for automated code reviews on this repo. Configure here.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 27, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​eth-snap-keyring@​21.0.1 ⏵ 22.0.09810091 -195 -150
Updated@​metamask/​keyring-internal-api@​10.1.1 ⏵ 11.0.01001007397100
Updated@​metamask/​eth-money-keyring@​2.0.2 ⏵ 2.0.3731008194100
Updated@​metamask/​eth-hd-keyring@​14.0.1 ⏵ 14.1.099 +110010094 +1100

View full report

@ccharly ccharly marked this pull request as ready for review April 27, 2026 09:01
@ccharly ccharly requested review from a team as code owners April 27, 2026 09:01
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c47a59d. Configure here.

Comment thread packages/account-tree-controller/src/rules/snap.ts
@ccharly ccharly force-pushed the cc/chore/bump-accounts-deps branch from c47a59d to 9fb82b2 Compare April 28, 2026 15:11
hmalik88
hmalik88 previously approved these changes Apr 28, 2026
salimtb
salimtb previously approved these changes Apr 28, 2026
aganglada
aganglada previously approved these changes Apr 28, 2026
@ccharly ccharly enabled auto-merge April 28, 2026 16:23
jiexi
jiexi previously approved these changes Apr 28, 2026
ffmcgee725
ffmcgee725 previously approved these changes Apr 28, 2026
@ccharly ccharly dismissed stale reviews from jiexi, aganglada, salimtb, and hmalik88 via a4a9db3 April 28, 2026 19:07
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ccharly ccharly added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit dd26617 Apr 28, 2026
366 checks passed
@ccharly ccharly deleted the cc/chore/bump-accounts-deps branch April 28, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants