prevent traces from breaking mobile app#8586
Merged
Conversation
4d22643 to
9c517d4
Compare
Prithpal-Sooriya
previously approved these changes
Apr 27, 2026
aae5cf8 to
ee070e4
Compare
Prithpal-Sooriya
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When calling
tracereturns undefined, trying to catch the promise will break the app. This prevents it.Mobile returns undefined in that callback.
References
Checklist
Note
Low Risk
Low risk: a small defensive change in telemetry code to tolerate
TraceCallbackimplementations that returnundefined, preventing runtime crashes without affecting asset fetching logic.Overview
Prevents
AssetsControllertelemetry from breaking the app by making#emitTracetoleratetraceimplementations that returnundefined(only calling.catch()when a promise is returned).Updates the
assets-controllerchangelog with a Fixed entry documenting the trace callback handling change.Reviewed by Cursor Bugbot for commit ee070e4. Bugbot is set up for automated code reviews on this repo. Configure here.