Skip to content

feat: add quickBuy and dappSwap FeatureIds#8598

Merged
micaelae merged 5 commits intomainfrom
swaps-featureid-qb-ds
Apr 27, 2026
Merged

feat: add quickBuy and dappSwap FeatureIds#8598
micaelae merged 5 commits intomainfrom
swaps-featureid-qb-ds

Conversation

@micaelae
Copy link
Copy Markdown
Member

@micaelae micaelae commented Apr 27, 2026

Explanation

Adds missing QuoteWarning and FeatureId enums. Clients already pass these in so the ts-expect-error suppressions will need to be removed

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Low runtime risk since this is type-only expansion, but medium integration risk because it’s a breaking public API change that may require downstream clients to update/remove type suppressions.

Overview
Updates bridge-controller public typings to recognize additional values used by external swap quote consumers.

Adds FeatureId.QUICK_BUY/FeatureId.DAPP_SWAP and extends QuoteWarning with market_closed and quote_expired, and documents both as BREAKING changes in the package changelog.

Reviewed by Cursor Bugbot for commit f371dc6. Bugbot is set up for automated code reviews on this repo. Configure here.

@micaelae micaelae marked this pull request as ready for review April 27, 2026 21:25
@micaelae micaelae requested review from a team as code owners April 27, 2026 21:25
@micaelae micaelae added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit b24ed44 Apr 27, 2026
362 checks passed
@micaelae micaelae deleted the swaps-featureid-qb-ds branch April 27, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants