feat: adds getByPositionId#8602
Merged
joaosantos15 merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
joaosantos15
had a problem deploying
to
default-branch
GitHub Actions
Failure
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
xavier-brochard
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Expose GET /v1/traders/position/:positionId through SocialService as fetchPositionById, returning a single Position by ID. Reuses the existing Position type and PositionStruct validator; no new response types needed.
References
Checklist
Note
Low Risk
Additive change that introduces a new read-only API wrapper method with schema validation and test coverage; minimal impact on existing flows.
Overview
Adds
SocialService.fetchPositionByIdto retrieve a singlePositionviaGET /v1/traders/position/:positionId, including URL-encoding, caching viafetchQuery, and response validation with the existingPositionStruct.Exposes the method through messenger action types/exports, introduces
FetchPositionByIdOptionsplus new error messages, and adds unit tests + changelog entry for the new endpoint wrapper.Reviewed by Cursor Bugbot for commit 495c91e. Bugbot is set up for automated code reviews on this repo. Configure here.