Allow Advanced Permissions metadata in signtypeddata payload#8603
Merged
jeffsmale90 merged 1 commit intomainfrom Apr 28, 2026
Merged
Allow Advanced Permissions metadata in signtypeddata payload#8603jeffsmale90 merged 1 commit intomainfrom
jeffsmale90 merged 1 commit intomainfrom
Conversation
51e1409 to
17f9432
Compare
FrederikBolding
approved these changes
Apr 28, 2026
jpuri
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
#8526 adds tighter validation to signtypeddata v4 payloads, to ensure that no extraneous properties are added.
This additional validation disallows Advanced Permissions
metadatawhich is used to communicate the origin and justification of the permission.This change loosens the validation just enough to allow
metadata: { justification: string; origin: string }as a property on the payload that is not used within the message encoding.References
#8526
MetaMask/metamask-extension#42181
Checklist
Note
Medium Risk
Touches security-adjacent request validation for typed-data signing; while the new
metadataallowance is tightly constrained, any loosening here could affect input filtering behavior.Overview
Relaxes
signTypedData(V4) payload validation to permit an additional top-levelmetadatafield used by Advanced Permissions.validateTypedMessageKeysnow explicitly allowsmetadataand enforces it is exactly{ justification: string, origin: string }(rejecting non-objects, missing/typed fields, or extra keys), with new unit tests covering the allowed and rejected cases; changelog updated accordingly.Reviewed by Cursor Bugbot for commit 17f9432. Bugbot is set up for automated code reviews on this repo. Configure here.