Skip to content

fix: send chomp timestamp as number instead of string#8610

Merged
Jwhiles merged 2 commits intomainfrom
fix-associate-address-type
Apr 28, 2026
Merged

fix: send chomp timestamp as number instead of string#8610
Jwhiles merged 2 commits intomainfrom
fix-associate-address-type

Conversation

@Jwhiles
Copy link
Copy Markdown
Contributor

@Jwhiles Jwhiles commented Apr 28, 2026

Explanation

When attempting to associate an address with chomp, we would send the timestamp as a string, when the API actually expects a number. This PR changes to type, and also the call site in the upgrade controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Introduces a breaking type change for AssociateAddressParams.timestamp, which can impact any callers/tests still providing a string. Runtime behavior change is small and localized to the CHOMP associate-address flow.

Overview
Fixes the CHOMP associate-address flow to use a numeric Date.now() timestamp end-to-end, updating the signed message and the payload sent to ChompApiService:associateAddress (and adjusting the associated unit test).

Updates @metamask/chomp-api-service types so AssociateAddressParams.timestamp is a number (breaking change) and records the change in both packages’ changelogs.

Reviewed by Cursor Bugbot for commit 91e11f7. Bugbot is set up for automated code reviews on this repo. Configure here.

@Jwhiles Jwhiles force-pushed the fix-associate-address-type branch from 91ddee7 to 91e11f7 Compare April 28, 2026 10:17
@Jwhiles Jwhiles marked this pull request as ready for review April 28, 2026 10:21
@Jwhiles Jwhiles requested review from a team as code owners April 28, 2026 10:21
@Jwhiles Jwhiles added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit 3716ceb Apr 28, 2026
362 checks passed
@Jwhiles Jwhiles deleted the fix-associate-address-type branch April 28, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants