fix: send chomp timestamp as number instead of string#8610
Merged
Conversation
91ddee7 to
91e11f7
Compare
MoMannn
approved these changes
Apr 28, 2026
shane-t
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When attempting to associate an address with chomp, we would send the timestamp as a string, when the API actually expects a number. This PR changes to type, and also the call site in the upgrade controller.
References
Checklist
Note
Medium Risk
Introduces a breaking type change for
AssociateAddressParams.timestamp, which can impact any callers/tests still providing a string. Runtime behavior change is small and localized to the CHOMP associate-address flow.Overview
Fixes the CHOMP associate-address flow to use a numeric
Date.now()timestamp end-to-end, updating the signed message and the payload sent toChompApiService:associateAddress(and adjusting the associated unit test).Updates
@metamask/chomp-api-servicetypes soAssociateAddressParams.timestampis anumber(breaking change) and records the change in both packages’ changelogs.Reviewed by Cursor Bugbot for commit 91e11f7. Bugbot is set up for automated code reviews on this repo. Configure here.