Skip to content

fix: transaction execution when accountOverride is present for postquote transaction#8615

Merged
jpuri merged 20 commits into
mainfrom
acc_override_postquote_fix
May 12, 2026
Merged

fix: transaction execution when accountOverride is present for postquote transaction#8615
jpuri merged 20 commits into
mainfrom
acc_override_postquote_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Apr 28, 2026

Explanation

In case of postquote transaction with accountOverride add delegation to execute quote on behalf of the override account.

References

Related to https://consensyssoftware.atlassian.net/browse/CONF-1323

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Changes the Relay post-quote submission path to swap a prepended original tx for a delegation tx when accountOverride is used, affecting how batched transactions are constructed and submitted. Incorrect delegation construction or account-detection could break post-quote execution for overridden accounts.

Overview
Fixes Relay post-quote submission when accountOverride is present by detecting from divergence and replacing the prepended original transaction with a delegation transaction built via TransactionPayController:getDelegationTransaction.

Adds buildDelegatedOriginalParams to fetch and inject the delegation tx params, updates batching logic accordingly, and extends relay-submit.test.ts with coverage ensuring the delegation is requested/used only when an override is set. Updates the package changelog to document the fix.

Reviewed by Cursor Bugbot for commit f93b79e. Bugbot is set up for automated code reviews on this repo. Configure here.

@jpuri jpuri changed the title fix: transaction execution when accountOverride is present for postqu… fix: transaction execution when accountOverride is present for postquote transaction May 12, 2026
@jpuri jpuri marked this pull request as ready for review May 12, 2026 06:11
@jpuri jpuri requested review from a team as code owners May 12, 2026 06:11
@jpuri jpuri enabled auto-merge May 12, 2026 06:11
@jpuri jpuri temporarily deployed to default-branch May 12, 2026 06:11 — with GitHub Actions Inactive
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 60a7c68. Configure here.

Comment thread packages/transaction-pay-controller/CHANGELOG.md Outdated
Co-authored-by: Ömer Göktuğ Poyraz <omergoktugpoyraz@gmail.com>
@jpuri jpuri requested a review from OGPoyraz May 12, 2026 08:38
OGPoyraz
OGPoyraz previously approved these changes May 12, 2026
@jpuri jpuri requested a review from OGPoyraz May 12, 2026 10:08
@jpuri jpuri added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit 1e5443a May 12, 2026
366 checks passed
@jpuri jpuri deleted the acc_override_postquote_fix branch May 12, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants