feat: Allow overriding action handler in subclass#8617
Merged
Conversation
Member
Author
|
@metamaskbot publish-preview |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
FrederikBolding
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This adds a new protected
getActionmethod to theMessengerclass which returns the actual handler implementation function. In most cases this is simply the handler registered in the#actionsproperty (i.e., throughregisterActionHandler).I ran into the problem when implementing the UI messenger that no actions were registered on the UI messenger itself (since it's just a wrapper around a connection to the client background), meaning delegation does not work, and had to call the internal
_internalRegisterDelegatedActionHandlermethod to make the UI and route messengers work. Making thegetActionmethod overridable enables much cleaner delegation in the UI messenger. See this diff for a comparison: MetaMask/metamask-extension@3610b3b.References
Checklist
Note
Cursor Bugbot is generating a summary for commit 5fd10d1. Configure here.