fix: perps flip position and suppress transient HL SDK sentry errors#8707
Merged
fix: perps flip position and suppress transient HL SDK sentry errors#8707
Conversation
Member
Author
|
@metamaskbot publish-preview |
geositta
approved these changes
May 5, 2026
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
There was a regression that got introduced with flipping position. This change to the controller fixes it properly. Also adds a change to mitigate SDK sentry errors
References
Mobile PRs:
ORDER_PRICE_REQUIREDerror on perps position flip metamask-mobile#29691Checklist
Note
Medium Risk
Touches HyperLiquid order placement and subscription error handling; mistakes could block trades or hide real connectivity issues, but changes are localized and mainly adjust validation/logging behavior.
Overview
Fixes a flip-position regression by restructuring
HyperLiquidProvider.placeOrder()to fetch a live price up front, validate market orders against thateffectivePrice, and reuse it in the $10-minimum retry path whencurrentPriceis omitted.Reduces Sentry noise in
HyperLiquidSubscriptionServiceby classifying additional Hyperliquid/rewslifecycle errors as transient (e.g., reconnect/timeout/termination cases), logging them todebugLoggerinstead of Sentry, and reusing the same transient detector to decide when to retryassetCtxssubscription reconnects.Reviewed by Cursor Bugbot for commit 938a7fe. Bugbot is set up for automated code reviews on this repo. Configure here.