Skip to content

refactor(multichain-account-service): remove old unused event#8752

Merged
ccharly merged 3 commits into
mainfrom
cc/fix/remove-old-event
May 11, 2026
Merged

refactor(multichain-account-service): remove old unused event#8752
ccharly merged 3 commits into
mainfrom
cc/fix/remove-old-event

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented May 11, 2026

Explanation

I forgot to remove this event in my previous PR:

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk cleanup that only tightens messenger event typings/delegations and updates related lint suppression/changelog entries; behavioral impact should be limited to consumers that still attempted to delegate/subscribe to KeyringController:stateChange.

Overview
Removes the unused KeyringController:stateChange subscription from multichain-account-service by dropping it from the test messenger delegation list and from the service’s AllowedEvents type.

Updates supporting metadata: deletes the now-unneeded ESLint suppression for src/tests/messenger.ts and tweaks the changelog entry to reflect that KeyringController:stateChange is no longer required (and references the follow-up PR).

Reviewed by Cursor Bugbot for commit c7eb0e9. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly requested a review from a team as a code owner May 11, 2026 07:35
@ccharly ccharly temporarily deployed to default-branch May 11, 2026 07:35 — with GitHub Actions Inactive
@ccharly ccharly requested a review from a team as a code owner May 11, 2026 07:36
@ccharly ccharly enabled auto-merge May 11, 2026 07:42
@ccharly ccharly added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit fc15a1c May 11, 2026
366 checks passed
@ccharly ccharly deleted the cc/fix/remove-old-event branch May 11, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants