Release/974.0.0#8755
Conversation
|
Warning MetaMask internal reviewing guidelines:
|
Restore changelog entries for prior releases that were inadvertently reformatted by the release tooling, keeping only the 974.0.0 release content.
Mrtenz
left a comment
There was a problem hiding this comment.
Looks good to me other than sample-controllers needing a major bump.
Major version bump reflects the BREAKING changes in this release (SampleGasPricesService now inherits from BaseDataService; onRetry, onBreak, and onDegraded removed).
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 898f4a8. Configure here.
| { | ||
| "name": "@metamask/accounts-controller", | ||
| "version": "38.0.0", | ||
| "version": "38.1.0", |
There was a problem hiding this comment.
Minor/patch bumps for major dependency upgrades violate semver
High Severity
@metamask/accounts-controller is bumped from 38.0.0 to 38.1.0 (minor), but its dependency on @metamask/network-controller is bumped from ^30.1.0 to ^31.0.0 (major). Consumers who also depend on @metamask/network-controller@^30.x will face unresolvable version conflicts when upgrading to accounts-controller@38.1.0, since ^30.x and ^31.0.0 are incompatible ranges. The same pattern applies broadly: many packages (gas-fee-controller, polling-controller, ens-controller, earn-controller, multichain-network-controller, etc.) receive only patch/minor bumps while bumping major dependencies on network-controller (^30.x → ^31.0.0) and/or controller-utils (^11.x → ^12.0.0). Per the reviewer's comment, these need to be major bumps.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 898f4a8. Configure here.


Explanation
References
Checklist
Note
Medium Risk
Primarily dependency/version bumps, but it pulls in breaking major releases of
@metamask/controller-utils@12and@metamask/network-controller@31, which can break downstream typed event listeners and service policy handlers.Overview
Bumps the monorepo release version to
974.0.0and rolls forward many internal package versions/changelogs.Most packages are updated to depend on
@metamask/controller-utils@12.0.0and@metamask/network-controller@31.0.0(plus related patch bumps like@metamask/message-manager@14.1.2,@metamask/polling-controller@16.0.5, etc.), propagating the new breaking event payload/type changes through the dependency graph.Reviewed by Cursor Bugbot for commit 898f4a8. Bugbot is set up for automated code reviews on this repo. Configure here.