Skip to content

fix: Move gasless flag to extended pay config#8810

Merged
pedronfigueiredo merged 6 commits into
mainfrom
pnf/gasless-enabled-extended-flag
May 14, 2026
Merged

fix: Move gasless flag to extended pay config#8810
pedronfigueiredo merged 6 commits into
mainfrom
pnf/gasless-enabled-extended-flag

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented May 14, 2026

What changed

  • Moved the Relay execute toggle to confirmations_pay_extended.payStrategies.relay.gaslessEnabled.
  • Renamed the flag back to gaslessEnabled and removed transaction-pay-controller source/test references to isGaslessEnabled.
  • Updated feature flag tests for the new remote flag namespace.
  • Updated the transaction-pay-controller changelog entry to reference this PR.

Why

This keeps confirmations_pay available for the existing release-scoped flag while allowing the new release behavior to be controlled from confirmations_pay_extended.

Validation

  • yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/utils/feature-flags.test.ts
  • yarn workspace @metamask/transaction-pay-controller run test
  • yarn workspace @metamask/transaction-pay-controller run changelog:validate
  • yarn build

Note

Medium Risk
Medium risk because it changes the remote feature-flag lookup path/name that gates the Relay /execute gasless flow; misconfiguration could unintentionally enable/disable gasless execution.

Overview
Updates the Relay gasless execute toggle to read from remoteFeatureFlags.confirmations_pay_extended.payStrategies.relay.gaslessEnabled (renaming from isGaslessEnabled and removing the old confirmations_pay location).

Adjusts isRelayExecuteEnabled unit tests to match the new namespace/key, and updates the changelog to document the flag move.

Reviewed by Cursor Bugbot for commit 9b57908. Bugbot is set up for automated code reviews on this repo. Configure here.

@pedronfigueiredo pedronfigueiredo changed the title [codex] Move gasless flag to extended pay config fix: Move gasless flag to extended pay config May 14, 2026
@pedronfigueiredo pedronfigueiredo marked this pull request as ready for review May 14, 2026 10:43
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners May 14, 2026 10:43
Comment thread packages/transaction-pay-controller/src/utils/feature-flags.ts
payStrategies?: {
relay?: {
enabled?: boolean;
gaslessEnabled?: boolean;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we only used this property currently?

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f72415. Configure here.

Comment thread packages/transaction-pay-controller/src/utils/feature-flags.ts
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit d81aeea May 14, 2026
370 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/gasless-enabled-extended-flag branch May 14, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants