use MetaMask/action-check-version@v1.0
#882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
approved these changes
Jul 29, 2022
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
You might want to add a README for the action repo so we know what it does and how to use it (feel free to copy from other action repos). Aside from that this looks good!
Contributor
Author
|
closing in favour of #883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we updated the configuration to cut releases from
mainin #863 I added a script that checks to ensure the version has been incremented before continuing with the release. I've now gone ahead and authored a separate GitHub action (MetaMask/action-check-version) to accomplish this so we no longer need to have this script littered across repositories.I've tested this out in my fork and you can view the action run here:
https://github.com/rickycodes/controllers/runs/7580492528?check_suite_focus=true