refactor(wallet-cli): enforce RPC param validation at dispatch time via superstruct

[sirtimid]

Summary

Resolves #8777.

• Adds RpcHandler<TParams, TResult>, RpcHandlerDefinition<TParams, TResult> ({ paramsStruct, run }), and a defineHandler(paramsStruct, run) helper in daemon/types.ts. RpcHandlerMap now maps method names to definitions.
• rpc-socket-server.ts validates params against the handler's struct via superstruct.validate before dispatch and returns -32602 invalidParams on shape mismatch. Each handler body can now trust the shape of its argument.
• daemon-entry.ts:
  • getStatus uses literal(null).
  • call uses a defined struct that enforces a non-empty [string, ...Json[]] tuple, dropping the ad-hoc Array.isArray / typeof checks from the handler body.
  • Replaces the wallet.messenger.call as any cast with a single typed RpcDispatcher = messenger.call.bind(messenger) escape hatch.
• Adds @metamask/superstruct ^3.1.0 to wallet-cli (already used across the monorepo at this version).

Test plan

• yarn workspace @metamask/wallet-cli run test — 248 tests pass, 100% line/branch/function/statement coverage on the touched files.
• yarn lint:eslint packages/wallet-cli/src — clean.
• yarn constraints — clean.
• yarn workspace @metamask/wallet-cli run changelog:validate — clean.
• New server test covers the -32602 invalidParams path and verifies run is not invoked when the struct rejects.
• New struct tests on the call handler cover both the rejection cases (null, empty, non-string head, non-array) and the accepting case.

🤖 Generated with Claude Code

---

Note

Medium Risk
Changes how the Unix-socket daemon validates and dispatches RPC params (including the full messenger call surface); behavior shifts from handler-thrown errors to -32602 for bad shapes, with filesystem permissions still the main access control.

Overview
Daemon JSON-RPC handlers are now { paramsStruct, run } definitions (via defineHandler) instead of plain async functions. rpc-socket-server validates incoming params with @metamask/superstruct before calling run, returning JSON-RPC -32602 invalidParams when validation fails and skipping the handler.

getStatus and listActions expect null params; call uses a custom struct for a non-empty [action, ...args] tuple, removing in-handler array checks. Messenger dispatch is centralized through a single RpcDispatcher bind/cast on wallet.messenger.call.

Shutdown now logs and continues if dispose() throws (same pattern as handle.close()). Tests were updated for the new handler shape and cover struct rejection, -32602, and dispose errors during shutdown.

^{Reviewed by Cursor Bugbot for commit 6dcb9c9. Bugbot is set up for automated code reviews on this repo. Configure here.}