fix(assets-controller): re-run snap discovery on snap install#8862
Merged
Conversation
Subscribe to `SnapController:snapInstalled` so that keyring snap chain discovery is re-triggered whenever a new snap is installed. This ensures snap-backed chains (Bitcoin, Solana, Tron, etc.) appear in `activeChains` immediately after install without waiting for a permission state change.
1192c06 to
c512559
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bf74ff7. Configure here.
Prithpal-Sooriya
approved these changes
May 20, 2026
7 tasks
sgextcsi
pushed a commit
to sgextcsi/metamask-extension-ne-regression
that referenced
this pull request
May 20, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This resolves a weird issue where the TRON snap is not loaded on startup causing issues with Asset Balances for TRON. This is first time install issue, closing and opening fixes. Convo here: https://consensys.slack.com/archives/CTQAGKY5V/p1779204701371199 But the underlying issue still needs debugging. 1. Is the background waiting for all snaps to load before initialising engine, or are there floating promises? 2. Why does this order changing resolve our issues, is there a recent change on the Tron Snap? We have a longer term, improved, fix on our Assets Controllers side here: MetaMask/core#8862 ----- **EDIT** Doing some digging, the preinstalled snaps are installed correctly inside the `background.js` with no floating promises. However the `SnapController.init()` - which processes these preinstalled snaps - is a floating promise. So while all other controllers are loading, the SnapController may not have finished its `init()`. - Front loading the non-evm snaps biases the startup _reducing_ the chance of missing non-EVM snaps on first install. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: https://consensys.slack.com/archives/CTQAGKY5V/p1779204701371199 ## **Manual testing steps** 1. Fresh app install 2. Navigate to TRON 3. EXPECTED: see if TRON native tokens are available. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Subscribe to
SnapController:snapInstalledso that keyring snap chain discovery is re-triggered whenever a new snap is installed. This ensures snap-backed chains (Bitcoin, Solana, Tron, etc.) appear inactiveChainsimmediately after install without waiting for a permission state change.Explanation
References
Checklist
Note
Medium Risk
Adds a new required messenger event (
SnapController:snapInstalled) forSnapDataSource, which is a breaking integration change for hosts using restricted messengers; functional logic change is small but could prevent snap chain discovery if not wired.Overview
Ensures snap-backed chains become available immediately after installing a new snap by having
SnapDataSourcesubscribe toSnapController:snapInstalledand re-run keyring snap discovery.Updates messenger typing so
SnapControllerSnapInstalledEventis included inSnapDataSourceAllowedEvents, and documents the resulting breaking requirement in theassets-controllerchangelog for hosts that restrict allowed events.Reviewed by Cursor Bugbot for commit bf74ff7. Bugbot is set up for automated code reviews on this repo. Configure here.