Skip to content

fix(assets-controller): re-run snap discovery on snap install#8862

Merged
salimtb merged 2 commits into
mainfrom
fix/snap-data-source-snap-installed-rediscovery
May 20, 2026
Merged

fix(assets-controller): re-run snap discovery on snap install#8862
salimtb merged 2 commits into
mainfrom
fix/snap-data-source-snap-installed-rediscovery

Conversation

@salimtb
Copy link
Copy Markdown
Contributor

@salimtb salimtb commented May 20, 2026

Subscribe to SnapController:snapInstalled so that keyring snap chain discovery is re-triggered whenever a new snap is installed. This ensures snap-backed chains (Bitcoin, Solana, Tron, etc.) appear in activeChains immediately after install without waiting for a permission state change.

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Adds a new required messenger event (SnapController:snapInstalled) for SnapDataSource, which is a breaking integration change for hosts using restricted messengers; functional logic change is small but could prevent snap chain discovery if not wired.

Overview
Ensures snap-backed chains become available immediately after installing a new snap by having SnapDataSource subscribe to SnapController:snapInstalled and re-run keyring snap discovery.

Updates messenger typing so SnapControllerSnapInstalledEvent is included in SnapDataSourceAllowedEvents, and documents the resulting breaking requirement in the assets-controller changelog for hosts that restrict allowed events.

Reviewed by Cursor Bugbot for commit bf74ff7. Bugbot is set up for automated code reviews on this repo. Configure here.

Subscribe to `SnapController:snapInstalled` so that keyring snap chain
discovery is re-triggered whenever a new snap is installed. This ensures
snap-backed chains (Bitcoin, Solana, Tron, etc.) appear in `activeChains`
immediately after install without waiting for a permission state change.
@salimtb salimtb force-pushed the fix/snap-data-source-snap-installed-rediscovery branch from 1192c06 to c512559 Compare May 20, 2026 14:30
@salimtb salimtb marked this pull request as ready for review May 20, 2026 14:37
@salimtb salimtb requested review from a team as code owners May 20, 2026 14:37
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bf74ff7. Configure here.

Comment thread packages/assets-controller/src/data-sources/SnapDataSource.ts
@salimtb salimtb temporarily deployed to default-branch May 20, 2026 14:40 — with GitHub Actions Inactive
@salimtb salimtb added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 7389a3c May 20, 2026
374 checks passed
@salimtb salimtb deleted the fix/snap-data-source-snap-installed-rediscovery branch May 20, 2026 15:50
sgextcsi pushed a commit to sgextcsi/metamask-extension-ne-regression that referenced this pull request May 20, 2026
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This resolves a weird issue where the TRON snap is not loaded on startup
causing issues with Asset Balances for TRON. This is first time install
issue, closing and opening fixes. Convo here:
https://consensys.slack.com/archives/CTQAGKY5V/p1779204701371199

But the underlying issue still needs debugging.
1. Is the background waiting for all snaps to load before initialising
engine, or are there floating promises?
2. Why does this order changing resolve our issues, is there a recent
change on the Tron Snap?

We have a longer term, improved, fix on our Assets Controllers side
here: MetaMask/core#8862

-----

**EDIT**

Doing some digging, the preinstalled snaps are installed correctly
inside the `background.js` with no floating promises.
However the `SnapController.init()` - which processes these preinstalled
snaps - is a floating promise.
So while all other controllers are loading, the SnapController may not
have finished its `init()`.
- Front loading the non-evm snaps biases the startup _reducing_ the
chance of missing non-EVM snaps on first install.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensys.slack.com/archives/CTQAGKY5V/p1779204701371199

## **Manual testing steps**

1. Fresh app install
2. Navigate to TRON
3. EXPECTED: see if TRON native tokens are available.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants