feat(wallet): add injectable fetch and prevClientVersion options#8879
Draft
grypez wants to merge 1 commit into
Draft
feat(wallet): add injectable fetch and prevClientVersion options#8879grypez wants to merge 1 commit into
grypez wants to merge 1 commit into
Conversation
- fetch: overrides the fetch implementation used by NetworkController's RPC service; defaults to globalThis.fetch. Allows platform-specific implementations (e.g. React Native) to be injected. - prevClientVersion: passed to RemoteFeatureFlagController to trigger feature-flag cache invalidation when the client version changes. Closes #8793, #8794 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of a stack on top of #8853.
fetchfield toWalletOptions— overrides thefetchimplementation used byNetworkController's RPC service. Defaults toglobalThis.fetch. Allows platform-specific fetch implementations (e.g. React Native) to be injected without subclassing.prevClientVersionfield toWalletOptions— passed toRemoteFeatureFlagControllerto trigger feature-flag cache invalidation when the client version changes between sessions.Closes #8793, #8794
Test plan
yarn workspace @metamask/wallet run testpassesyarn constraintspassesyarn validate:changelogpasses🤖 Generated with Claude Code