feat(wallet): expose initializationConfigurations on the Wallet constructor#8881
Draft
grypez wants to merge 2 commits into
Draft
feat(wallet): expose initializationConfigurations on the Wallet constructor#8881grypez wants to merge 2 commits into
grypez wants to merge 2 commits into
Conversation
…ructor Allows callers to pass an array of InitializationConfiguration objects to override or extend the default controller set. Overridden controllers replace their default counterpart by name; additional controllers are appended to the initialization sequence. Closes #8795 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Exercises the map callback in initialize() that extracts overridden names, which was previously uncovered because no test passed a non-empty initializationConfigurations array. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of a stack on top of #8880.
initializationConfigurations?: InitializationConfiguration<unknown, unknown>[]to theWalletconstructor.namematches a default controller replace it; configurations with novel names are appended after the defaults.Wallet.Closes #8795
Test plan
yarn workspace @metamask/wallet run testpasses (includes a test that passes a custom config and verifies itsinitis called)yarn constraintspassesyarn validate:changelogpasses🤖 Generated with Claude Code