fix(transaction-controller): pass isInternal when submitting extra transactions batch#8884
Merged
matthewwalsh0 merged 1 commit intoMay 28, 2026
Merged
Conversation
matthewwalsh0
force-pushed
the
fix/transaction-controller-duplicate-batch-id
branch
from
f15c67e to
4678f2f
Compare
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
matthewwalsh0
changed the title
matthewwalsh0
force-pushed
the
fix/transaction-controller-duplicate-batch-id
branch
from
4678f2f to
3136fcd
Compare
matthewwalsh0
temporarily deployed
to
default-branch
GitHub Actions
Inactive
…sPublishHook batch call
matthewwalsh0
force-pushed
the
fix/transaction-controller-duplicate-batch-id
branch
from
3136fcd to
2e22f8d
Compare
dan437
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
ExtraTransactionsPublishHookcallsaddTransactionBatchto submit an ERC-20 gas-fee-token payment alongside a Smart Transaction, but was not passingisInternal: true. The duplicate-batch-ID guard introduced in #8633 then threwDuplicateBundleId(error 5720) because the sharedbatchIdlooked like an untrusted external call.Fix: pass
isInternal: trueat theExtraTransactionsPublishHookcall site.References
isInternalflag #8633Checklist
Note
Low Risk
Single call-site flag fix with tests; no auth or API surface changes beyond correcting internal batch submission.
Overview
Marks nested ERC-20 gas-fee-token batches submitted by
ExtraTransactionsPublishHookas trusted internal work by passingisInternal: trueintoaddTransactionBatch.After the explicit internal-flag change in v66, that hook reused the parent
batchIdwithout the flag, so the duplicate-batch guard treated it like an external caller and threwDuplicateBundleId(5720). Tests and the changelog document the fix.Reviewed by Cursor Bugbot for commit 2e22f8d. Bugbot is set up for automated code reviews on this repo. Configure here.