Skip to content

chore(keyring-controller): deprecate KeyringTypes #8907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ccharly merged 2 commits into from
May 27, 2026
+6 −0
Merged

chore(keyring-controller): deprecate KeyringTypes #8907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59eff36
chore(keyring-controller): deprecate KeyringTypes
ccharly May 27, 2026
b472f9a
chore: changelog
ccharly May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/keyring-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- **BREAKING:** Change `KeyringSelectorV2` type selectors for `withKeyringV2` and `withKeyringV2Unsafe` to use `KeyringType` (v2 variant) ([#8901](https://github.com/MetaMask/core/pull/8901))
- Use values such as `KeyringType.Hd` instead of legacy `KeyringTypes.hd`.
- Deprecate `KeyringTypes` ([#8907](https://github.com/MetaMask/core/pull/8907))
- Use `KeyringTypes` from `@metamask/keyring-api/v2` if your keyring has a v2 builder.

## [25.5.0]

Expand Down
4 changes: 4 additions & 0 deletions packages/keyring-controller/src/KeyringController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ const MESSENGER_EXPOSED_METHODS = [

/**
* Available keyring types
*
* @deprecated Use `KeyringType` from `@metamask/keyring-api/v2` instead. This enum will be removed
* in a future release once V2 is fully adopted. Only use it if the keyring you are trying to access
* has no V2 builder available yet.
*/
export enum KeyringTypes {
// Changing this would be a breaking change, and not worth the effort at this
Expand Down
Loading