Skip to content

Remove extractFromFile#8937

Merged
cryptodev-2s merged 2 commits into
feat/messenger-docs-sitefrom
remove-extract-from-file
May 29, 2026
Merged

Remove extractFromFile#8937
cryptodev-2s merged 2 commits into
feat/messenger-docs-sitefrom
remove-extract-from-file

Conversation

@mcmire
Copy link
Copy Markdown
Contributor

@mcmire mcmire commented May 29, 2026

Explanation

It seems extractFromFile was only used in tests but nowhere else. extractFromSourceFile is the true public method.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
API removal only affects consumers of the removed helper; extraction logic is untouched and tests preserve the same scenarios.

Overview
Removes the extractFromFile convenience API from platform-api-docs so callers use createExtractionProject plus extractFromSourceFile only—the path intended for real batch extraction.

Tests are updated to match: a shared extractFromWrittenFile helper writes fixtures, loads sibling .ts / .d.cts files into a project, and runs extractFromSourceFile. The suite is renamed from extractFromFile to extractFromSourceFile; extraction behavior is unchanged.

Reviewed by Cursor Bugbot for commit edd9bbd. Bugbot is set up for automated code reviews on this repo. Configure here.

It seems `extractFromFile` was only used in tests but nowhere else.
`extractFromSourceFile` is the true public method.
@mcmire mcmire requested a review from a team as a code owner May 29, 2026 17:20
@cryptodev-2s cryptodev-2s merged commit 920602d into feat/messenger-docs-site May 29, 2026
368 checks passed
@cryptodev-2s cryptodev-2s deleted the remove-extract-from-file branch May 29, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants