Remove extractFromFile#8937
Merged
Merged
Conversation
It seems `extractFromFile` was only used in tests but nowhere else. `extractFromSourceFile` is the true public method.
cryptodev-2s
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
It seems
extractFromFilewas only used in tests but nowhere else.extractFromSourceFileis the true public method.References
Checklist
Note
Low Risk
API removal only affects consumers of the removed helper; extraction logic is untouched and tests preserve the same scenarios.
Overview
Removes the
extractFromFileconvenience API fromplatform-api-docsso callers usecreateExtractionProjectplusextractFromSourceFileonly—the path intended for real batch extraction.Tests are updated to match: a shared
extractFromWrittenFilehelper writes fixtures, loads sibling.ts/.d.ctsfiles into a project, and runsextractFromSourceFile. The suite is renamed fromextractFromFiletoextractFromSourceFile; extraction behavior is unchanged.Reviewed by Cursor Bugbot for commit edd9bbd. Bugbot is set up for automated code reviews on this repo. Configure here.