fix: transaction parameters for batch swap transactions

[micaelae]

Explanation

Fixes batch-sell submission edge case which causes tx failure if gasIncluded7702=true and STX is enabled. See changelog for exact parameters changed

In addition to these changes, clients need to update the TransactionController publishHook to prioritize publishing via 7702 if isGasFeeIncluded=true. The current logic submits using STX although the quote requires 7702 processing

Example transaction-controller-init change

+  const isSwapGasIncluded7702 = transactionMeta.isGasFeeIncluded;
   let attemptedHook = false;
 
   if (
     keyringSupports7702 &&
     !isRevokeDelegation &&
-    (!isSmartTransaction || !sendBundleSupport || isExternalSign)
+    (isSwapGasIncluded7702 || !isSmartTransaction || !sendBundleSupport || isExternalSign)
    ) {
     const hook = new Delegation7702PublishHook({
      messenger: initMessenger,
    }).getHook();

References

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

High Risk
Changes how batched swaps choose 7702 vs STX paths and how fees are paid; misconfiguration can cause submission failures, and full behavior depends on a coordinated TransactionController publishHook update in clients.

Overview
Fixes gas and EIP-7702 batch options passed from BridgeStatusController into TransactionController for batched swaps and batch-sell flows, addressing failures when quotes use gas-included 7702 with STX enabled or ERC-20–denominated fees.

Batch swap strategy now derives gasFeeToken from the quote’s TX_FEE asset (omitted when the fee asset is native), and sets skipInitialGasEstimate / excludeNativeTokenForFee from that token and from gasIncluded7702 plus whether the account is already delegated. shouldDisable7702 is tightened so delegated accounts only keep 7702 enabled when the quote is not plain gasIncluded STX gasless.

Batch-sell uses the same skipInitialGasEstimate and excludeNativeTokenForFee rules. toTransactionParams accepts bridge-api fee fields whether they are already hex or numeric strings.

Tests and snapshots cover native vs ERC-20 gasless swaps and the updated batch params. Clients still need a separate publishHook change so isGasFeeIncluded quotes publish via 7702 instead of STX when required.

^{Reviewed by Cursor Bugbot for commit 402df45. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Inverted excludeNativeTokenForFee flag

High Severity

Batch submission sets excludeNativeTokenForFee to !gasFeeToken, so when an ERC20 gasFeeToken is provided the flag is false. TransactionController only forces fee payment via gasFeeToken when excludeNativeTokenForFee is true with a token set, so ERC20 gasless swaps can fall back to native balance.

Additional Locations (1)

• packages/bridge-status-controller/src/strategy/batch-sell-strategy.ts#L69-L70

 

^{Reviewed by Cursor Bugbot for commit 9e44080. Configure here.}

[micaelae]

This is intentional. Prevents failures if the user has a native balance but it's not enough to cover network fees

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 402df45. Configure here.}

[cursor]

Empty native fee sets gasFeeToken

Low Severity

When TX_FEE uses a native asset with an empty-string address (valid per isNativeAddress), the gasFeeToken expression falls through to the else branch and passes an empty hex string instead of undefined, so batch params can carry a bogus gasFeeToken rather than treating the fee as native.

 

^{Reviewed by Cursor Bugbot for commit 402df45. Configure here.}

[micaelae]

This is not possible, it's either zero address or a hex