fix: skip already-aligned accounts during wallet alignment#9269
Merged
Conversation
mathieuartu
temporarily deployed
to
default-branch
GitHub Actions
Inactive
montelaidev
reviewed
Jun 29, 2026
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds exact-range account group alignment. This is mainly done to fix Sentry unnecessary spam, but can also improve performance slightly.
References
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1939
Checklist
Note
Medium Risk
Changes core wallet alignment and account-creation scheduling; behavior is more selective but miscomputed sub-ranges could leave groups misaligned until a later align run.
Overview
Wallet alignment no longer calls
createAccountsfor every provider across the full group index range. It now derives contiguous sub-ranges where each provider is missing an account and only invokes creation for those gaps.MultichainAccountGroupgainsisProviderAligned(provider), and groupisAligned()is implemented via that helper.MultichainAccountWalletrefactors the shared build path from#buildGroupStateForRangeto#buildGroupStatewith agetSubRangescallback: alignment supplies#getUnalignedSubRangesForProvider, while group creation still passes the full[from, to]range. Providers that are already aligned for all indices in the range are skipped entirely (fewer traces / Sentry noise).Tests cover single missing indices, fully aligned providers, and non-contiguous missing indices (separate
createAccountscalls per gap).Reviewed by Cursor Bugbot for commit 851ec05. Bugbot is set up for automated code reviews on this repo. Configure here.