Merged
Conversation
Mrtenz
approved these changes
Nov 18, 2025
cryptodev-2s
force-pushed
the
add-preview-builds
branch
from
cd0182c to
804f197
Compare
Mrtenz
approved these changes
Nov 18, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - name: Checkout and setup environment | ||
| uses: MetaMask/action-checkout-and-setup@v1 | ||
| with: | ||
| is-high-risk-environment: true |
There was a problem hiding this comment.
Bug: Incorrect branch checkout defeats preview builds.
The MetaMask/action-checkout-and-setup@v1 action likely performs a repository checkout that overwrites the PR branch checked out in the previous step (line 60). This would cause the workflow to build and publish from the default branch instead of the PR branch, defeating the purpose of preview builds. The action should either be removed or configured to skip the checkout step if that's supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, you can post a comment in a PR with the content @metamaskbot publish-preview, and it will build the branch and publish it under the @metamask-previews under a special version. This works very similarly to how it works in core.
Note
Introduce a preview-build workflow triggered by PR comments, with scripts to scope/version packages for previews and README docs on using them.
/.github/workflows/publish-preview.ymlto publish preview builds on@metamaskbot publish-previewissue comments.--tag preview, and comments back with build info.scripts/prepare-preview-builds.shandscripts/prepare-preview-builds.jqto rewritepackage.jsonfor previews (scope to@metamask-previews, append-preview-<short_sha>to version) and reinstall deps.scripts/generate-preview-build-message.shto output install identifier for the preview build.README.mdwith instructions for creating, using, and updating preview builds (including Yarn/NPM override examples).Written by Cursor Bugbot for commit 804f197. This will update automatically on new commits. Configure here.