Open
Conversation
AllowanceRevocationEnforcerApprovalRevocationEnforcer
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 84896cd. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What?
This enforcer grants the authority to revoke allowances granted by either:
approve(spender,amount)approve(to,tokenId)setApprovalForAll(operator,approved)This covers approvals set for ERC20, ERC721 and ERC1155 tokens.
Why?
The enforcer now verifies that the target implements the expected token standard, by first invoking the standard-specific function to check the allowance being revoked.
Advanced Permissions currently has an
erc20-token-revocationpermission that grants the authority to revoke only ERC20 approvals. NFT approvals are also required.By combining these revocations into a single enforcer, we get a number of benefits:
How?
The enforcer accepts no terms.
The
beforeHookfirst performs general verification - no native value is being sent, execution calldata is the expected length.setApprovalForAllandapproveare distinguished by selector. The differentapprovesignatures are distinguished by thespender/toparameter - if it is the zero address, it is presumed to be the ERC721 styleapprove(to, tokenId).Note
Medium Risk
Adds a new enforcer that gates token approval revocations (ERC-20/721/1155) and performs on-chain allowance/approval pre-checks; mistakes could unintentionally block valid revocations or cause unexpected reverts, especially in redelegation chains due to link-local
_delegatorsemantics.Overview
Introduces
ApprovalRevocationEnforcer, a new caveat enforcer that permits delegates to only revoke existing approvals via tightly-scoped calls: ERC-20approve(spender, 0), ERC-721approve(address(0), tokenId), and ERC-721/1155setApprovalForAll(operator, false), controlled by a 1-byte terms bitmask.beforeHooknow enforces single/default mode, zero native value, exact calldata shape, and verifies the target’s current approval state (allowance,getApproved,isApprovedForAll) before allowing the revocation; extensive unit/integration tests and docs were added, and deployment/verification scripts were updated to include the new enforcer.Reviewed by Cursor Bugbot for commit 9583d15. Bugbot is set up for automated code reviews on this repo. Configure here.