lift all explorer link generation logic to etherscan-link repo #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
lift-getBlockExplorerLinkForChain-to-etherscanlink
branch
from
9a3518d to
f8aa4c8
Compare
adonesky1
force-pushed
the
lift-getBlockExplorerLinkForChain-to-etherscanlink
branch
from
f8aa4c8 to
5a03419
Compare
kumavis
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to lift the utility explorer link generation method, created in this PR, which makes use of etherscan-link methods, into this repo.
I will pull tests over and open a PR to remove the corresponding method in the metamask-extension repo if folks think this is a good move.