Lift getAccountLink / Create getTokenTracker / Add tests for getBlockExplorerUrlForTx #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
changed the title
… format based on args
adonesky1
changed the title
adonesky1
force-pushed
the
add-getBlockExplorerUrlForTx-tests
branch
from
1e2aaaf to
d8bb45c
Compare
adonesky1
force-pushed
the
add-getBlockExplorerUrlForTx-tests
branch
from
d8bb45c to
a432a28
Compare
brad-decker
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to complete the pattern proposed in this PR . We had begun to build utility methods in the extension repo to select the appropriate url generation method (using either custom network, chainId or networkId). Here I've continued the work of lifting these selector methods into the etherscan-link repo. Ideally the selector methods (getBlockExplorerLink, getAccountLink, getTokenTrackerLink) would have a matching function signature/api however they have slightly different required arguments.
Included work: