feat(gh-action): align version management mobile and extension#73
Merged
Conversation
These changes are for unifying the release process between extension and
mobile, including made the same release version branch, which is
different at the moment.
It will create `"release/${new_version}"` branches as a pattern.
For testing, we don't wanna execute the spreadsheet step, just create the commits csv file.
To allow to re-run the workflow, in case there aren't changes to push to remote
Gudahtt
reviewed
Jun 9, 2025
This will tackle the same things for mobile and extensions, adding the conditionals to execute mobile specific steps
and remove unused commented lines
Contributor
|
@alucardzom Do you have test runs? |
Contributor
Author
Yes @Qbandev , added to the description, test runs were made as also indicated on Jira within this repo: |
Qbandev
previously approved these changes
Jun 11, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the release process for mobile and extension platforms by aligning version management and branch naming conventions. The key changes include:
- Adding a new input (github-tools-version) and logging step in the release workflow.
- Enhancing the semantic version update script with improved validation and mobile-specific checks.
- Standardizing release branch naming and improving error handling in the platform release PR creation script.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/create-release-pr.yml | Added new input for github-tools-version and a step to print input values. |
| .github/scripts/set-semvar-version.sh | Improved input validation, added mobile version consistency check, and updated logs. |
| .github/scripts/create-platform-release-pr.sh | Unified release branch naming and added checks for existing PRs and branch setup. |
Comments suppressed due to low confidence (1)
.github/scripts/set-semvar-version.sh:1
- The file is named 'set-semvar-version.sh' while the script uses the term 'SEMVER_VERSION' in comments and variables. To maintain clarity and consistency, consider renaming the file to 'set-semver-version.sh'.
#!/usr/bin/env bash
Qbandev
approved these changes
Jun 11, 2025
jluque0101
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are for unifying the release process between extension and mobile, including made the same release version branch, which is different at the moment.
It will create
"release/${new_version}"branches as a pattern.https://github.com/MetaMask/MetaMask-planning/issues/4858
Tests runs:
https://github.com/MetaMask/experimental-metamask-extension-dso-tests/actions/workflows/create-release-pr.yml