Conversation
📖 Storybook Preview |
|
|
||
| ### Changed | ||
|
|
||
| - Updated `AvatarFavicon` type internals to use ADR-0003/ADR-0004 shared types; imports from `@metamask/design-system-react` are unchanged ([#1062](https://github.com/MetaMask/metamask-design-system/pull/1062)) |
There was a problem hiding this comment.
| - Updated `AvatarFavicon` type internals to use ADR-0003/ADR-0004 shared types; imports from `@metamask/design-system-react` are unchanged ([#1062](https://github.com/MetaMask/metamask-design-system/pull/1062)) | ||
| - **BREAKING:** Migrated `Text` typography types (`TextVariant`, `TextColor`, `FontWeight`, `FontStyle`, `FontFamily`) to `@metamask/design-system-shared`; all imports through `@metamask/design-system-react` continue to work without change ([#1047](https://github.com/MetaMask/metamask-design-system/pull/1047)) | ||
| - `FontWeight`, `FontStyle`, and `FontFamily` underlying string values changed to semantic identifiers (e.g. `FontWeight.Bold` was `'font-bold'`, now `'bold'`); idiomatic usage is unaffected | ||
| - Projects scanning `node_modules` for Tailwind class names must also scan `@metamask/design-system-shared` |
There was a problem hiding this comment.
The Tailwind scanning note is the less-obvious half of this breaking change. Consumers who scan node_modules for Tailwind class names (e.g. to include text-primary-default from TextColor) will silently miss classes after this release because the string values now live in @metamask/design-system-shared's compiled output. Full migration details are in MIGRATION.md.
| ### Added | ||
|
|
||
| - Added `IconAlertSeverity` and `IconAlertPropsShared` shared types for cross-platform use ([#1060](https://github.com/MetaMask/metamask-design-system/pull/1060)) | ||
| - Added `AvatarFaviconSize` and `AvatarFaviconPropsShared` shared types for cross-platform use ([#1062](https://github.com/MetaMask/metamask-design-system/pull/1062)) |
There was a problem hiding this comment.
Both additions follow the same ADR-0003/0004 pattern: a const object (e.g. IconAlertSeverity) paired with a PropsShared type. Centralising them here means both React and React Native packages can derive their platform-specific prop types from a single source of truth without duplicating the enum values.
Release 33.0.0
This release captures two features that landed on
mainafter Release 32.0.0 was cut —IconAlert(new React Native component) and theAvatarFaviconADR-0003/0004 type migration — plus theTexttypography type migration that was inadvertently omitted from Release 32.0.0.📦 Package Versions
@metamask/design-system-shared: 0.11.0@metamask/design-system-react: 0.17.0@metamask/design-system-react-native: 0.18.0🔄 Shared Type Updates (0.11.0)
IconAlert and AvatarFavicon shared types (#1060, #1062)
What Changed:
IconAlertSeverityandIconAlertPropsSharedshared types for cross-platform useAvatarFaviconSizeandAvatarFaviconPropsSharedshared types for cross-platform useImpact:
🌐 React Web Updates (0.17.0)
Changed
Texttypography types (TextVariant,TextColor,FontWeight,FontStyle,FontFamily) to@metamask/design-system-shared; all imports through@metamask/design-system-reactcontinue to work without change (#1047)FontWeight,FontStyle, andFontFamilyunderlying string values changed to semantic identifiers (e.g.FontWeight.Boldwas'font-bold', now'bold'); idiomatic usage is unaffectednode_modulesfor Tailwind class names must also scan@metamask/design-system-sharedAvatarFavicontype internals to use ADR-0003/ADR-0004 shared types; imports from@metamask/design-system-reactare unchanged (#1062)📱 React Native Updates (0.18.0)
Added
IconAlertcomponent for mapping a severity (info,success,warning,error) to a fixed icon glyph and theme color (#1060)Changed
AvatarFavicontype internals to use ADR-0003/ADR-0004 shared types; imports from@metamask/design-system-react-nativeare unchanged (#1062)Text typography types moved to shared package (React Web Only)
What Changed:
FontWeight,FontStyle,FontFamily,TextVariant, andTextColornow defined in@metamask/design-system-sharedand re-exported from@metamask/design-system-reactFontWeight,FontStyle, andFontFamilyunderlying string values changed to semantic identifiersMigration:
See React Migration Guide for complete instructions.
✅ Checklist
yarn changelog:validate)Pre-merge author checklist
yarn build && yarn test && yarn lint)yarn changelog:validate)Pre-merge reviewer checklist
Note
Low Risk
This is primarily a release bookkeeping PR (version bumps + changelog entries) with no code changes; risk is limited to publishing the intended package versions and documenting the noted breaking type migration.
Overview
Bumps the monorepo release to
33.0.0and increments package versions for@metamask/design-system-shared(0.11.0),@metamask/design-system-react(0.17.0), and@metamask/design-system-react-native(0.18.0).Updates changelogs to capture the included releases, including new shared types for
IconAlert/AvatarFaviconand the documented breakingTexttypography type migration to@metamask/design-system-shared.Reviewed by Cursor Bugbot for commit 3360891. Bugbot is set up for automated code reviews on this repo. Configure here.