chore: fixing button base storybook docs page #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
4
to
+16
|
|
||
| <Meta of={ButtonBaseStories} /> | ||
|
|
||
| # ButtonBase | ||
|
|
||
| `ButtonBase` is a labeled element that a user can click or tap to initiate an action. | ||
|
|
||
| <Canvas of={ButtonBaseStories.Default} /> | ||
|
|
||
| ```tsx | ||
| import { ButtonBase } from '@metamask/design-system-react'; | ||
|
|
||
| <ButtonBase onClick={() => {}}>Button Base</ButtonBase>; | ||
| ``` | ||
|
|
||
| <Canvas of={ButtonBaseStories.Default} /> | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Removes <Meta and rearranging Canvas to show after code example
| import { Meta, Canvas, Story } from '@storybook/blocks'; | ||
| import * as TypographyStories from './Typography.stories'; | ||
|
|
||
| <Meta of={TypographyStories} /> |
Contributor
Author
There was a problem hiding this comment.
Remvoing last remaning <Meta from repo
brianacnguyen
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes documentation issues in Typograpgy and ButtonBase README.mdx file. The changes include:
<Meta>tag that was causing documentation display issues<Canvas>element to appear after the code example, maintaining a consistent pattern with other component documentationThese changes improve the readability and consistency of the component documentation in Storybook.
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
Documentation had incorrect placement of Storybook elements causing display issues.
After
Documentation follows consistent pattern with properly organized sections and examples.
Typography stories render as expected
Pre-merge author checklist
Pre-merge reviewer checklist