fix: dsrn example wallet screen #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
changed the title
Comment on lines
-4
to
+5
| '../../../packages/design-system-react-native/src/**/*.stories.@(js|jsx|ts|tsx)', | ||
| '../../../packages/design-system-react-native/src/**/!(temp-components)/*.stories.@(js|jsx|ts|tsx)', | ||
| '../stories/**/*.stories.@(js|jsx|ts|tsx)', |
Contributor
Author
There was a problem hiding this comment.
Updating storybook react native to include stories from apps/storybook-react-native
| } from "@storybook/react-native"; | ||
|
|
||
| global.STORIES = [ | ||
| { |
Contributor
Author
There was a problem hiding this comment.
Updating storybook requires using yarn prestorybook
georgewrmarshall
force-pushed
the
fix/dsrn-example-screen
branch
from
5f68ee5 to
a4449de
Compare
Contributor
📖 Storybook Preview |
georgewrmarshall
force-pushed
the
fix/dsrn-example-screen
branch
from
a4449de to
f1bdeaf
Compare
georgewrmarshall
commented
Jun 2, 2025
| export type { AvatarAccountProps } from './AvatarAccount'; | ||
|
|
||
| export { AvatarBase, AvatarBaseSize } from './AvatarBase'; | ||
| export { AvatarBase, AvatarBaseSize, AvatarBaseShape } from './AvatarBase'; |
Contributor
Author
There was a problem hiding this comment.
Missing AvatarBaseShape enum export
Contributor
📖 Storybook Preview |
georgewrmarshall
commented
Jun 2, 2025
Comment on lines
+98
to
+101
| <View style={tw`flex-col items-center justify-center`}> | ||
| <Icon name={IconName.Bank} /> | ||
| <Text fontWeight={FontWeight.Medium}>Buy/Sell</Text> | ||
| </View> |
Contributor
Author
There was a problem hiding this comment.
If we had access to the content wrapping View via a prop object we could use that instead but this works
georgewrmarshall
commented
Jun 2, 2025
| return ( | ||
| <ScrollView style={tw`bg-background-default flex-1`}> | ||
| {/* Container */} | ||
| <View style={tw`bg-background-default w-full py-4`}> |
Contributor
Author
There was a problem hiding this comment.
Need to allow for bg-default and other shorthand design token classnames similar to react
brianacnguyen
approved these changes
Jun 2, 2025
Contributor
📖 Storybook Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new WalletHome example story based on the home page redesign to the Storybook React Native app to:
Related issues
Part of: #654
Manual testing steps
yarn storybook:ios)Screenshots/Recordings
Before
N/A - New feature
After
after.mov
Pre-merge author checklist